Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2454123003: count timeout as a completed attempt. (Closed)

Created:
4 years, 1 month ago by Pete Williamson
Modified:
4 years, 1 month ago
Reviewers:
dougarnett
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

count timeout as a completed attempt. BUG=659723 Committed: https://crrev.com/e7946c136e121bd0ba9c567a00bff412c742c8bd Cr-Commit-Position: refs/heads/master@{#428835}

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback per DougArnett #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Pete Williamson
The unit tests were changed since we no don't call the OfflinerDoneTimeout, which would set ...
4 years, 1 month ago (2016-10-28 01:04:49 UTC) #2
dougarnett
https://codereview.chromium.org/2454123003/diff/1/components/offline_pages/background/request_coordinator.cc File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/2454123003/diff/1/components/offline_pages/background/request_coordinator.cc#newcode215 components/offline_pages/background/request_coordinator.cc:215: // If we timed out, let the offliner done ...
4 years, 1 month ago (2016-10-28 16:13:11 UTC) #3
Pete Williamson
Fixed per our discussion, bug to follow https://codereview.chromium.org/2454123003/diff/1/components/offline_pages/background/request_coordinator.cc File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/2454123003/diff/1/components/offline_pages/background/request_coordinator.cc#newcode215 components/offline_pages/background/request_coordinator.cc:215: // If ...
4 years, 1 month ago (2016-10-28 18:32:38 UTC) #4
dougarnett
lgtm
4 years, 1 month ago (2016-10-28 18:37:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454123003/40001
4 years, 1 month ago (2016-10-31 20:41:48 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-31 22:13:57 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 22:15:29 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7946c136e121bd0ba9c567a00bff412c742c8bd
Cr-Commit-Position: refs/heads/master@{#428835}

Powered by Google App Engine
This is Rietveld 408576698