third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp - Issue 2454123002: Refactor image decoders to use 'colorSpace' instead of 'colorProfile'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

Issue 2454123002: Refactor image decoders to use 'colorSpace' instead of 'colorProfile' (Closed)

Patch Set: Fix legacy ImageFrame Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

diff --git a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

index 0355222f31fbed0b9070339883ba1116a650f125..90aea4e63d3bd276be70ab6b0cb0d740e411d677 100644

--- a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

+++ b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

@@ -279,10 +279,9 @@ void ImageBitmapFactories::ImageBitmapLoader::decodeImageOnDecoderThread(

ImageDecoder::AlphaOption alphaOp = ImageDecoder::AlphaPremultiplied;

if (premultiplyAlphaOption == "none")

alphaOp = ImageDecoder::AlphaNotPremultiplied;

- ImageDecoder::GammaAndColorProfileOption colorSpaceOp =

- ImageDecoder::GammaAndColorProfileApplied;

+ ImageDecoder::ColorSpaceOption colorSpaceOp = ImageDecoder::ColorSpaceApplied;

if (colorSpaceConversionOption == "none")

- colorSpaceOp = ImageDecoder::GammaAndColorProfileIgnored;

+ colorSpaceOp = ImageDecoder::ColorSpaceIgnored;

std::unique_ptr<ImageDecoder> decoder(ImageDecoder::create(

SegmentReader::createFromSkData(SkData::MakeWithoutCopy(

arrayBuffer->data(), arrayBuffer->byteLength())),