Allow backgrounding processes on Mac

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 2787 matching lines @@
     channel_->Unpause(false /* flush */);
 
     if (child_connection_) {
       child_connection_->SetProcessHandle(
           child_process_launcher_->GetProcess().Handle());
     }
 
     // Not all platforms launch processes in the same backgrounded state. Make
     // sure |is_process_backgrounded_| reflects this platform's initial process
     // state.
+#if defined(OS_MACOSX)
+    is_process_backgrounded_ =
+        child_process_launcher_->GetProcess().IsProcessBackgrounded(
+            MachBroker::GetInstance());
+#else
     is_process_backgrounded_ =
         child_process_launcher_->GetProcess().IsProcessBackgrounded();
+#endif  // defined(OS_MACOSX)
 
-    // Disable updating process priority on startup for now as it incorrectly
-    // results in backgrounding foreground navigations until their first commit
-    // is made. A better long term solution would be to be aware of the tab's
-    // visibility at this point. https://crbug.com/560446.
-    // Except on Android for now because of https://crbug.com/601184 :-(.
+// Disable updating process priority on startup for now as it incorrectly

[shrike, 2016/10/31 17:26:05]

It seems like this comment should stay at its current indentation level?

[lgrey, 2016/10/31 19:22:02]

This was from git cl format. Is it OK to override it?

[shrike, 2016/10/31 20:32:36]

As long as your change follows the spec it should be OK to change what git cl
format does. That said, this formatting should be based on the brace nesting
level, so it would be surprising for it to be wrong. I applied your patch and
the formatting looks correct - I don't know what's going on but it seems like
leaving as is should be OK.

[Nico, 2016/11/01 02:07:27]

`git cl format` aligns comments in front of a preprocessor directive with the
alignment of the following preprocessor directive (or the prior one, don't
remember right now). If you don't want this, move the comment after the
preprocessor directive.

+// results in backgrounding foreground navigations until their first commit
+// is made. A better long term solution would be to be aware of the tab's
+// visibility at this point. https://crbug.com/560446.
+// Except on Android for now because of https://crbug.com/601184 :-(.
 #if defined(OS_ANDROID)
     UpdateProcessPriority();
 #endif
 
     // Share histograms between the renderer and this process.
     CreateSharedRendererHistogramAllocator();
   }
 
   // NOTE: This needs to be before flushing queued messages, because
   // ExtensionService uses this notification to initialize the renderer process
@@ skipping 158 matching lines @@
   bad_message::ReceivedBadMessage(render_process_id,
                                   bad_message::RPH_MOJO_PROCESS_ERROR);
 }
 
 void RenderProcessHostImpl::CreateURLLoaderFactory(
     mojo::InterfaceRequest<mojom::URLLoaderFactory> request) {
   URLLoaderFactoryImpl::Create(resource_message_filter_, std::move(request));
 }
 
 }  // namespace content