Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2454053004: Don't apply maximized window bounds workaround if bounds aren't changed (Closed)

Created:
4 years, 1 month ago by atimoxin
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't apply maximized window bounds workaround if bounds aren't changed In HWNDMessageHandler::OnWindowPosChanging() was added code that restores correct maximized window's bounds after attaching or detaching additional display (see crrev.com/6bb7f8192). But this workaround also applied if OnWindowPosChanging() was called with SWP_NOMOVE/SWP_NOSIZE flags that leads to bugs such as crbug.com/659525 and crbug.com/655984. This CL adds additional check for SWP_NOMOVE/SWP_NOSIZE flags before applying workaround and fixes this bugs. BUG=659525, 655984 Committed: https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065 Cr-Commit-Position: refs/heads/master@{#428368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
atimoxin
4 years, 1 month ago (2016-10-28 11:47:40 UTC) #2
sky
LGTM
4 years, 1 month ago (2016-10-28 13:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454053004/1
4 years, 1 month ago (2016-10-28 13:45:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 14:52:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6279588b7ebc740f85409107dd91b5c3ce628065 Cr-Commit-Position: refs/heads/master@{#428368}
4 years, 1 month ago (2016-10-28 14:55:03 UTC) #8
sky
4 years, 1 month ago (2016-11-07 17:17:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2482933002/ by sky@chromium.org.

The reason for reverting is: This resulted in a shortcut to move between
monitors not working. See 656001..

Powered by Google App Engine
This is Rietveld 408576698