MD Settings: Fix <select> search highlighting.

chrome/browser/resources/settings/search_settings.js

Index: chrome/browser/resources/settings/search_settings.js
diff --git a/chrome/browser/resources/settings/search_settings.js b/chrome/browser/resources/settings/search_settings.js
index 0a74ff014beefc354ab7e74e53af65ccf67e2417..de59b6f04ffdd81c4222ac7d958f9d483f9f25d8 100644
--- a/chrome/browser/resources/settings/search_settings.js
+++ b/chrome/browser/resources/settings/search_settings.js
@@ -149,7 +149,11 @@ cr.define('settings', function() {
         if (request.regExp.test(textContent)) {
           foundMatches = true;
           revealParentSection_(node, request.rawQuery_);
-          highlight_(node, textContent.split(request.regExp));
+
+          // Don't highlight <select> nodes (yellow rectangles can't be
+          // displayed. Just revealing the section is sufficient.

[dpapad, 2016/10/27 01:24:48]

Highlighting <select> elements with a search bubble instead of yellow rectangles
might be a nice improvement over the previous Options UI. We can file a bug and
prioritize separately though (prefer not
to do it in this CL).

+          if (node.parentNode.nodeName != 'OPTION')
+            highlight_(node, textContent.split(request.regExp));
         }
         // Returning early since TEXT_NODE nodes never have children.
         return;