MD Settings: Fix <select> search highlighting.

chrome/browser/resources/settings/search_settings.js

Index: chrome/browser/resources/settings/search_settings.js
diff --git a/chrome/browser/resources/settings/search_settings.js b/chrome/browser/resources/settings/search_settings.js
index 0a74ff014beefc354ab7e74e53af65ccf67e2417..6a5d06ce9660745643347e6fc3516be84a7926b8 100644
--- a/chrome/browser/resources/settings/search_settings.js
+++ b/chrome/browser/resources/settings/search_settings.js
@@ -149,7 +149,12 @@ cr.define('settings', function() {
         if (request.regExp.test(textContent)) {
           foundMatches = true;
           revealParentSection_(node, request.rawQuery_);
-          highlight_(node, textContent.split(request.regExp));
+
+          // Don't highlight <select> nodes, yellow rectangles can't be
+          // displayed within an <option>. Just revealing the section is
+          // sufficient.
+          if (node.parentNode.nodeName != 'OPTION')

[Dan Beam, 2016/10/27 21:37:14]

wait, why can't we just point an arrow at the <select>?

[Dan Beam, 2016/10/27 21:46:09]

TODO(dpapad): highlight <select> controls even if we can't highlight the
<option>s.

[dpapad, 2016/10/27 22:14:21]

Added.

+            highlight_(node, textContent.split(request.regExp));
         }
         // Returning early since TEXT_NODE nodes never have children.
         return;