Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2453993004: Match server version of DM API proto. (Closed)

Created:
4 years, 1 month ago by Thiemo Nagel
Modified:
4 years, 1 month ago
Reviewers:
peletskyi
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, bartfab (slow)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match server version of DM API proto. Some fields are renamed: * new_public_key_verification_signature --> new_public_key_verification_signature_deprecated * PolicyPublicKeyAndDomain --> DEPRECATEDPolicyPublicKeyAndDomain * RemoteCommand.unique_id --> RemoteCommand.command_id BUG=645078 Committed: https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a Cr-Commit-Position: refs/heads/master@{#429257}

Patch Set 1 #

Patch Set 2 : Style and comment fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -55 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/policy/test/policy_testserver.py View 3 chunks +5 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/policy_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/remote_commands/remote_command_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/remote_commands/remote_commands_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/remote_commands/remote_commands_service.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/policy/core/common/remote_commands/testing_remote_commands_server.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/policy/proto/device_management_backend.proto View 1 9 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 35 (28 generated)
Thiemo Nagel
Sasha, could you please take a look? (bartfab cc fyi)
4 years, 1 month ago (2016-10-29 16:54:02 UTC) #24
Thiemo Nagel
Sasha, friendly ping?
4 years, 1 month ago (2016-11-02 10:33:51 UTC) #27
peletskyi
lgtm
4 years, 1 month ago (2016-11-02 10:57:37 UTC) #28
Thiemo Nagel
Thank you!
4 years, 1 month ago (2016-11-02 11:43:03 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453993004/80001
4 years, 1 month ago (2016-11-02 11:43:14 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 1 month ago (2016-11-02 12:39:29 UTC) #33
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 12:41:32 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78ff9da2c0349d700b15428c6da567c61b894f1a
Cr-Commit-Position: refs/heads/master@{#429257}

Powered by Google App Engine
This is Rietveld 408576698