Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2453973004: [compiler] Ship Ignition for all TurboFan code. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
mvstanton, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Ship Ignition for all TurboFan code. This enables Ignition unconditionally for all code that is destined for optimization with TurboFan. This ensures all optimization attempts will go through the BytecodeGraphBuilder and that the AstGraphBuilder pipe is dried out in practice. patch from issue 2427953002 at patchset 120001 (http://crrev.com/2427953002#ps120001) R=mvstanton@chromium.org,rmcilroy@chromium.org Committed: https://crrev.com/b4b436de6ad42e83d259418965a1a62c540a9fc7 Cr-Commit-Position: refs/heads/master@{#40663}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -51 lines) Patch
M src/compiler.cc View 1 2 chunks +31 lines, -27 lines 0 comments Download
M test/cctest/cctest.status View 3 chunks +23 lines, -13 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 chunks +5 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-management.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
Michael Starzinger
4 years, 1 month ago (2016-10-28 08:14:50 UTC) #5
rmcilroy
Awesome, LGTM, thanks!
4 years, 1 month ago (2016-10-28 15:42:25 UTC) #8
rmcilroy
Missed one comment: https://codereview.chromium.org/2453973004/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2453973004/diff/1/test/mjsunit/mjsunit.status#newcode66 test/mjsunit/mjsunit.status:66: # Issue 4680: The eval'ed code ...
4 years, 1 month ago (2016-10-28 15:42:41 UTC) #9
mvstanton
Fantastic, LGTM :)
4 years, 1 month ago (2016-10-31 05:11:58 UTC) #10
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/2453973004/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2453973004/diff/1/test/mjsunit/mjsunit.status#newcode66 test/mjsunit/mjsunit.status:66: # Issue 4680: The eval'ed code ...
4 years, 1 month ago (2016-10-31 09:10:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453973004/20001
4 years, 1 month ago (2016-10-31 09:41:20 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 09:43:25 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:40 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4b436de6ad42e83d259418965a1a62c540a9fc7
Cr-Commit-Position: refs/heads/master@{#40663}

Powered by Google App Engine
This is Rietveld 408576698