Add test case that navigates to an extension blob from inside of devtools.

Add test case that navigates to an extension blob from inside of devtools.

BUG=656752
Committed: https://crrev.com/01a85bdd1110a2fb19b21dc25e2995fa30f4ba28
Cr-Commit-Position: refs/heads/master@{#428123}

[ncarter (slow), 2016-10-26 23:32:22]

nick@chromium.org changed reviewers:
+ alexmos@chromium.org

[ncarter (slow), 2016-10-26 23:32:23]

Alex, here's an extra bit of test coverage for the devtools case.

I actually kind of expected there to be a bug here; lmk if you see a way to
tweak this so that it would hit the ShouldAllowOpenURL case.

[alexmos, 2016-10-27 00:19:36]

LGTM.  I guess it doesn't hit the ShouldAllowOpenURL because you're doing a
renderer-initiated navigation of a local (just-created) frame, and to hit our
problematic case we'd need to navigate it via a proxy?  Doesn't seem like you
can get a proxy there, given that we don't isolate extensions in DevTools, but
this will be good to have when we do.

[ncarter (slow), 2016-10-27 17:30:02]

nick@chromium.org changed reviewers:
+ dgozman@chromium.org

[ncarter (slow), 2016-10-27 17:30:02]

dgozman: please review

[ncarter (slow), 2016-10-27 17:31:21]

Description was changed from

==========
Add test case that navigates to an extension blob from inside of devtools.

BUG=
==========

to

==========
Add test case that navigates to an extension blob from inside of devtools.

BUG=656752
==========

[dgozman, 2016-10-27 17:43:51]

On 2016/10/27 17:30:02, ncarter wrote:
> dgozman: please review

Sorry, I don't have access to the bug and have no context of what's happening
here.

[ncarter (slow), 2016-10-27 18:12:45]

I've added you to the bug. Sorry for the lacking context.

As background, there's no devtools bug here as far as we know. I thought there
might be, and there's a risk that the in-progress fix for 656752 would regress
this corner case. Hence this test.

Devtools is a case where we have chrome-extension content outside of a
chrome-extension siteinstance, so it's fragile to being broken by some of the
"chrome extension activity should only happen inside of chrome extension
processes" enforcement that becomes possible with --isolate-extensions mode,
which is now enabled by default.

[dgozman, 2016-10-27 19:20:07]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-10-27 19:20:08]

On 2016/10/27 18:12:45, ncarter wrote:
> I've added you to the bug. Sorry for the lacking context.
> 
> As background, there's no devtools bug here as far as we know. I thought there
> might be, and there's a risk that the in-progress fix for 656752 would regress
> this corner case. Hence this test.
> 
> Devtools is a case where we have chrome-extension content outside of a
> chrome-extension siteinstance, so it's fragile to being broken by some of the
> "chrome extension activity should only happen inside of chrome extension
> processes" enforcement that becomes possible with --isolate-extensions mode,
> which is now enabled by default.

Thanks for the context. +caseq for in-process extensions thoughts, maybe we
could try to move them out of process to not being a special-case which will
helps with avoiding any breakages.

Patch lgtm.

[ncarter (slow), 2016-10-27 19:28:18]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:29:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:17:35]

Description was changed from

==========
Add test case that navigates to an extension blob from inside of devtools.

BUG=656752
==========

to

==========
Add test case that navigates to an extension blob from inside of devtools.

BUG=656752
==========

[commit-bot: I haz the power, 2016-10-27 20:17:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-27 20:19:59]

Description was changed from

==========
Add test case that navigates to an extension blob from inside of devtools.

BUG=656752
==========

to

==========
Add test case that navigates to an extension blob from inside of devtools.

BUG=656752

Committed: https://crrev.com/01a85bdd1110a2fb19b21dc25e2995fa30f4ba28
Cr-Commit-Position: refs/heads/master@{#428123}
==========

[commit-bot: I haz the power, 2016-10-27 20:20:00]

Patchset 1 (id:??) landed as
https://crrev.com/01a85bdd1110a2fb19b21dc25e2995fa30f4ba28
Cr-Commit-Position: refs/heads/master@{#428123}