Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2453943002: Exit VR Shell on pause (And fix a bunch of minor bugs). (Closed)

Created:
4 years, 1 month ago by mthiesse
Modified:
4 years, 1 month ago
Reviewers:
cjgrant, gone, bshe
CC:
chromium-reviews, agrieve+watch_chromium.org, cjgrant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exit VR Shell on pause (And fix a bunch of minor bugs). Also fixed a possible bug where we'd incorrectly reset rotation. Fixed a bug where the control container was hidden on resume, and pages without scrolling couldn't bring it back. Fixed a crash exiting VR shortly after entering. BUG=653182, 659707 Committed: https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620 Cr-Commit-Position: refs/heads/master@{#428132}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comment #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 2 8 chunks +18 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
mthiesse
PTAL
4 years, 1 month ago (2016-10-26 22:10:22 UTC) #2
cjgrant
https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc (right): https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc#newcode45 chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc:45: if (!vr_shell_) Why proceed here with no UI?
4 years, 1 month ago (2016-10-27 14:33:17 UTC) #4
mthiesse
https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc (right): https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc#newcode45 chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc:45: if (!vr_shell_) On 2016/10/27 14:33:17, cjgrant wrote: > Why ...
4 years, 1 month ago (2016-10-27 14:37:03 UTC) #5
bshe
https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc (right): https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc#newcode45 chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc:45: if (!vr_shell_) On 2016/10/27 14:33:17, cjgrant wrote: > Why ...
4 years, 1 month ago (2016-10-27 14:37:11 UTC) #6
bshe
On 2016/10/27 14:37:11, bshe wrote: > https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc > File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc (right): > > https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc#newcode45 > ...
4 years, 1 month ago (2016-10-27 14:39:25 UTC) #7
mthiesse
https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc File chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc (right): https://codereview.chromium.org/2453943002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc#newcode45 chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc:45: if (!vr_shell_) On 2016/10/27 14:37:11, bshe wrote: > On ...
4 years, 1 month ago (2016-10-27 14:45:55 UTC) #9
mthiesse
+dfalcantara@chromium.org for OWNERS stamp on chrome/android
4 years, 1 month ago (2016-10-27 14:47:13 UTC) #11
gone
lgtm
4 years, 1 month ago (2016-10-27 18:02:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453943002/20001
4 years, 1 month ago (2016-10-27 18:31:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/153643) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 1 month ago (2016-10-27 18:51:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453943002/40001
4 years, 1 month ago (2016-10-27 20:04:03 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-27 21:00:32 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 21:02:24 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620
Cr-Commit-Position: refs/heads/master@{#428132}

Powered by Google App Engine
This is Rietveld 408576698