Revert of [Mac/GN] Fix rebuilds when changing framework_version of a mac_framework_bundle.

Revert of [Mac/GN] Fix rebuilds when changing framework_version of a mac_framework_bundle. (patchset #1 id:1 of https://codereview.chromium.org/2453043002/ )

Reason for revert:
rules.gni file is causing the build failure.

------
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //build/config/mac/rules.gni:313:3: Script returned non-zero exit code.
  exec_script("//build/config/mac/prepare_framework_version.py",
  ^----------
Current dir: /b/c/b/Google_Chrome_Mac/src/out/Release/
Command: python -- /b/c/b/Google_Chrome_Mac/src/build/config/mac/prepare_framework_version.py /b/c/b/Google_Chrome_Mac/src/out/Release/obj/ui/base/ui_unittests_framework_version /b/c/b/Google_Chrome_Mac/src/out/Release/ui_unittests Framework.framework ''
Returned 1.

Original issue's description:
> [Mac/GN] Fix rebuilds when changing framework_version of a mac_framework_bundle.
>
> Write the current framework_version to a file at gen-time, and clobber the
> entire framework bundle if it differs from the current value in the file.
>
> This has to be done at gen-time because it is not possible to run a script at
> the create_bundle stage before any other dependencies in its tree run. Take
> this sample graph:
>
>                        bundle_data --> shared_library
>                       /
>   mac_framework_bundle
>                       \
>                        action("clean_framework_version")
>
> It is not possible, from a mac_framework_bundle, to force the
> clean_framework_version action to run before the shared_library. When the
> action does run, its stamp will have a newer mtime than the shared_library.
> Because bundle_data are hard linked into place, the link source file will
> have an older mtime than the action, and the build will never stabilize.
>
> BUG=648757
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/fed4fc1df8bab7159f19e04ed658c1f417e4e499
> Cr-Commit-Position: refs/heads/master@{#428183}

TBR=dpranke@chromium.org,brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648757
Committed: https://crrev.com/d76ba00e6cc2625000d495e79bdc8d747645405e
Cr-Commit-Position: refs/heads/master@{#428212}

[hongchan, 2016-10-27 23:31:14]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2016-10-27 23:31:15]

Created Revert of [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle.

[commit-bot: I haz the power, 2016-10-27 23:32:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:33:52]

Description was changed from

==========
Revert of [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle. (patchset #1 id:1 of
https://codereview.chromium.org/2453043002/ )

Reason for revert:
rules.gni file is causing the build failure.

------
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //build/config/mac/rules.gni:313:3: Script returned non-zero exit code.
  exec_script("//build/config/mac/prepare_framework_version.py",
  ^----------
Current dir: /b/c/b/Google_Chrome_Mac/src/out/Release/
Command: python --
/b/c/b/Google_Chrome_Mac/src/build/config/mac/prepare_framework_version.py
/b/c/b/Google_Chrome_Mac/src/out/Release/obj/ui/base/ui_unittests_framework_version
/b/c/b/Google_Chrome_Mac/src/out/Release/ui_unittests Framework.framework ''
Returned 1.

Original issue's description:
> [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle.
> 
> Write the current framework_version to a file at gen-time, and clobber the
> entire framework bundle if it differs from the current value in the file.
> 
> This has to be done at gen-time because it is not possible to run a script at
> the create_bundle stage before any other dependencies in its tree run. Take
> this sample graph:
> 
>                        bundle_data --> shared_library
>                       /
>   mac_framework_bundle
>                       \
>                        action("clean_framework_version")
> 
> It is not possible, from a mac_framework_bundle, to force the
> clean_framework_version action to run before the shared_library. When the
> action does run, its stamp will have a newer mtime than the shared_library.
> Because bundle_data are hard linked into place, the link source file will
> have an older mtime than the action, and the build will never stabilize.
> 
> BUG=648757
> R=dpranke@chromium.org
> 
> Committed: https://crrev.com/fed4fc1df8bab7159f19e04ed658c1f417e4e499
> Cr-Commit-Position: refs/heads/master@{#428183}

TBR=dpranke@chromium.org,brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648757
==========

to

==========
Revert of [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle. (patchset #1 id:1 of
https://codereview.chromium.org/2453043002/ )

Reason for revert:
rules.gni file is causing the build failure.

------
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //build/config/mac/rules.gni:313:3: Script returned non-zero exit code.
  exec_script("//build/config/mac/prepare_framework_version.py",
  ^----------
Current dir: /b/c/b/Google_Chrome_Mac/src/out/Release/
Command: python --
/b/c/b/Google_Chrome_Mac/src/build/config/mac/prepare_framework_version.py
/b/c/b/Google_Chrome_Mac/src/out/Release/obj/ui/base/ui_unittests_framework_version
/b/c/b/Google_Chrome_Mac/src/out/Release/ui_unittests Framework.framework ''
Returned 1.

Original issue's description:
> [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle.
> 
> Write the current framework_version to a file at gen-time, and clobber the
> entire framework bundle if it differs from the current value in the file.
> 
> This has to be done at gen-time because it is not possible to run a script at
> the create_bundle stage before any other dependencies in its tree run. Take
> this sample graph:
> 
>                        bundle_data --> shared_library
>                       /
>   mac_framework_bundle
>                       \
>                        action("clean_framework_version")
> 
> It is not possible, from a mac_framework_bundle, to force the
> clean_framework_version action to run before the shared_library. When the
> action does run, its stamp will have a newer mtime than the shared_library.
> Because bundle_data are hard linked into place, the link source file will
> have an older mtime than the action, and the build will never stabilize.
> 
> BUG=648757
> R=dpranke@chromium.org
> 
> Committed: https://crrev.com/fed4fc1df8bab7159f19e04ed658c1f417e4e499
> Cr-Commit-Position: refs/heads/master@{#428183}

TBR=dpranke@chromium.org,brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648757
==========

[commit-bot: I haz the power, 2016-10-27 23:33:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-27 23:39:35]

Description was changed from

==========
Revert of [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle. (patchset #1 id:1 of
https://codereview.chromium.org/2453043002/ )

Reason for revert:
rules.gni file is causing the build failure.

------
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //build/config/mac/rules.gni:313:3: Script returned non-zero exit code.
  exec_script("//build/config/mac/prepare_framework_version.py",
  ^----------
Current dir: /b/c/b/Google_Chrome_Mac/src/out/Release/
Command: python --
/b/c/b/Google_Chrome_Mac/src/build/config/mac/prepare_framework_version.py
/b/c/b/Google_Chrome_Mac/src/out/Release/obj/ui/base/ui_unittests_framework_version
/b/c/b/Google_Chrome_Mac/src/out/Release/ui_unittests Framework.framework ''
Returned 1.

Original issue's description:
> [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle.
> 
> Write the current framework_version to a file at gen-time, and clobber the
> entire framework bundle if it differs from the current value in the file.
> 
> This has to be done at gen-time because it is not possible to run a script at
> the create_bundle stage before any other dependencies in its tree run. Take
> this sample graph:
> 
>                        bundle_data --> shared_library
>                       /
>   mac_framework_bundle
>                       \
>                        action("clean_framework_version")
> 
> It is not possible, from a mac_framework_bundle, to force the
> clean_framework_version action to run before the shared_library. When the
> action does run, its stamp will have a newer mtime than the shared_library.
> Because bundle_data are hard linked into place, the link source file will
> have an older mtime than the action, and the build will never stabilize.
> 
> BUG=648757
> R=dpranke@chromium.org
> 
> Committed: https://crrev.com/fed4fc1df8bab7159f19e04ed658c1f417e4e499
> Cr-Commit-Position: refs/heads/master@{#428183}

TBR=dpranke@chromium.org,brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648757
==========

to

==========
Revert of [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle. (patchset #1 id:1 of
https://codereview.chromium.org/2453043002/ )

Reason for revert:
rules.gni file is causing the build failure.

------
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //build/config/mac/rules.gni:313:3: Script returned non-zero exit code.
  exec_script("//build/config/mac/prepare_framework_version.py",
  ^----------
Current dir: /b/c/b/Google_Chrome_Mac/src/out/Release/
Command: python --
/b/c/b/Google_Chrome_Mac/src/build/config/mac/prepare_framework_version.py
/b/c/b/Google_Chrome_Mac/src/out/Release/obj/ui/base/ui_unittests_framework_version
/b/c/b/Google_Chrome_Mac/src/out/Release/ui_unittests Framework.framework ''
Returned 1.

Original issue's description:
> [Mac/GN] Fix rebuilds when changing framework_version of a
mac_framework_bundle.
>
> Write the current framework_version to a file at gen-time, and clobber the
> entire framework bundle if it differs from the current value in the file.
>
> This has to be done at gen-time because it is not possible to run a script at
> the create_bundle stage before any other dependencies in its tree run. Take
> this sample graph:
>
>                        bundle_data --> shared_library
>                       /
>   mac_framework_bundle
>                       \
>                        action("clean_framework_version")
>
> It is not possible, from a mac_framework_bundle, to force the
> clean_framework_version action to run before the shared_library. When the
> action does run, its stamp will have a newer mtime than the shared_library.
> Because bundle_data are hard linked into place, the link source file will
> have an older mtime than the action, and the build will never stabilize.
>
> BUG=648757
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/fed4fc1df8bab7159f19e04ed658c1f417e4e499
> Cr-Commit-Position: refs/heads/master@{#428183}

TBR=dpranke@chromium.org,brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648757

Committed: https://crrev.com/d76ba00e6cc2625000d495e79bdc8d747645405e
Cr-Commit-Position: refs/heads/master@{#428212}
==========

[commit-bot: I haz the power, 2016-10-27 23:39:36]

Patchset 1 (id:??) landed as
https://crrev.com/d76ba00e6cc2625000d495e79bdc8d747645405e
Cr-Commit-Position: refs/heads/master@{#428212}

[Dirk Pranke, 2016-10-28 00:28:28]

lgtm