Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: base/metrics/field_trial_unittest.cc

Issue 2453933004: Fix deadlock issue with AllStatesToString (Closed)
Patch Set: fix nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/field_trial.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial_unittest.cc
diff --git a/base/metrics/field_trial_unittest.cc b/base/metrics/field_trial_unittest.cc
index be96aa6ceeab060339534704af7812457360f35e..0ad13a22be77e00e85cde99aa41b72af63fa79c5 100644
--- a/base/metrics/field_trial_unittest.cc
+++ b/base/metrics/field_trial_unittest.cc
@@ -1142,11 +1142,16 @@ TEST(FieldTrialListTest, TestCopyFieldTrialStateToFlags) {
base::FieldTrialList::CreateFieldTrial("Trial1", "Group1");
base::FilePath test_file_path = base::FilePath(FILE_PATH_LITERAL("Program"));
base::CommandLine cmd_line = base::CommandLine(test_file_path);
+ const char field_trial_handle[] = "test-field-trial-handle";
- base::FieldTrialList::CopyFieldTrialStateToFlags("field-trial-handle",
+ base::FieldTrialList::CopyFieldTrialStateToFlags(field_trial_handle,
&cmd_line);
-
+#if defined(OS_WIN)
+ EXPECT_TRUE(cmd_line.HasSwitch(field_trial_handle) ||
+ cmd_line.HasSwitch(switches::kForceFieldTrials));
+#else
EXPECT_TRUE(cmd_line.HasSwitch(switches::kForceFieldTrials));
+#endif
}
TEST(FieldTrialListTest, InstantiateAllocator) {
« no previous file with comments | « base/metrics/field_trial.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698