Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2453933003: Centralize mojo edk initialization path for some unit tests. (Closed)

Created:
4 years, 1 month ago by leonhsl(Using Gerrit)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Centralize mojo edk initialization path for some unit tests. This CL centralizes mojo edk initialization path into content::TestBlinkWebUnitTestSupport, instead of doing that in separated places: unit_tests, content_unittests, components_unittests, extensions_unittests, webkit_unit_tests and blink_fuzzer_test_support. BUG=none Committed: https://crrev.com/16319599c7ea406d03fbb402f905ccdc472114bd Cr-Commit-Position: refs/heads/master@{#428287}

Patch Set 1 #

Patch Set 2 : Remove mojo edk init path in blink_fuzzer_test_support #

Patch Set 3 : Revert change of third_party/WebKit/Source/platform/testing/DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/run_all_unittests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/test/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M components/test/components_test_suite.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/run_all_unittests.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/test/extensions_unittests_main.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/BlinkFuzzerTestSupport.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RunAllTests.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
leonhsl(Using Gerrit)
Would you PTAL at this? Thanks. I assume this makes sense even without any other ...
4 years, 1 month ago (2016-10-27 11:07:12 UTC) #11
jam
lgtm with checkdeps fix
4 years, 1 month ago (2016-10-27 18:27:22 UTC) #14
blundell
lgtm, thanks!
4 years, 1 month ago (2016-10-27 21:17:25 UTC) #15
leonhsl(Using Gerrit)
Uploaded ps#3 to fix checkdeps: I should not have removed including rule "mojo/edk/embedder" from third_party/WebKit/Source/platform/testing/DEPS, ...
4 years, 1 month ago (2016-10-28 03:42:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453933003/40001
4 years, 1 month ago (2016-10-28 03:42:49 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 05:02:57 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 05:06:22 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16319599c7ea406d03fbb402f905ccdc472114bd
Cr-Commit-Position: refs/heads/master@{#428287}

Powered by Google App Engine
This is Rietveld 408576698