Tweak 'scroll' listener registration in CrScrollableBehavior.

Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed).

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fdb78fe88a06d28e76bf0e46346c19d2578c871a
Cr-Commit-Position: refs/heads/master@{#427861}

[dpapad, 2016-10-26 20:50:23]

Description was changed from

==========
Correctly remove 'scroll' listener from CrScrollableBehavior.

BUG=658450
==========

to

==========
Correctly remove 'scroll' listener from CrScrollableBehavior.

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-26 21:43:58]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-26 21:46:25]

Description was changed from

==========
Correctly remove 'scroll' listener from CrScrollableBehavior.

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed). 

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-26 21:46:25]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-26 22:05:09]

Description was changed from

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed). 

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed). 

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-26 22:05:09]

dbeam@chromium.org changed reviewers:
+ stevenjb@chromium.org
- dbeam@chromium.org

[Dan Beam, 2016-10-26 22:05:31]

+stevenjb@ as majority author (I doubt attached -> ready makes much difference)

[stevenjb, 2016-10-26 22:19:32]

lgtm

[commit-bot: I haz the power, 2016-10-26 22:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:37:00]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-26 22:53:03]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:06:38]

Description was changed from

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed). 

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed). 

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-26 23:06:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 23:09:31]

Description was changed from

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed). 

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Tweak 'scroll' listener registration in CrScrollableBehavior.

Previously listeners were added in attached() and were unsuccessfully
removed in detached(). Unsuccessfully because removeEventListener() was
called with a different function reference than the one used in
addEventListener().

Now listeners are added in ready() which is guaranteed to execute once
regardless of how many times an element is attached/detached. Removing
the listeners is unncessary since a detached element can't be scrolled
anyway (and most likely will get GCed).

BUG=658450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fdb78fe88a06d28e76bf0e46346c19d2578c871a
Cr-Commit-Position: refs/heads/master@{#427861}
==========

[commit-bot: I haz the power, 2016-10-26 23:09:32]

Patchset 2 (id:??) landed as
https://crrev.com/fdb78fe88a06d28e76bf0e46346c19d2578c871a
Cr-Commit-Position: refs/heads/master@{#427861}