Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2453903003: Revert of [ios] Do not trigger context menu while scrolling. (Closed)

Created:
4 years, 1 month ago by bzanotti
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Do not trigger context menu while scrolling. (patchset #1 id:1 of https://codereview.chromium.org/2452973003/ ) Reason for revert: Breaking many integration tests on iOS downstream. Original issue's description: > [ios] Do not trigger context menu while scrolling. > > Fail _contextMenuRecognizer if webview's scroll view > panGestureRecognizer was recognized. > > BUG=642375 > > Committed: https://crrev.com/033350786362e99d206a97e0e656c2e0a478e3c9 > Cr-Commit-Position: refs/heads/master@{#427888} TBR=kkhorimoto@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642375 Committed: https://crrev.com/5abe79ab4b2768cb617e6bf97989aa093421078a Cr-Commit-Position: refs/heads/master@{#427966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bzanotti
Created Revert of [ios] Do not trigger context menu while scrolling.
4 years, 1 month ago (2016-10-27 08:46:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453903003/1
4 years, 1 month ago (2016-10-27 08:47:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 08:48:25 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 08:51:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5abe79ab4b2768cb617e6bf97989aa093421078a
Cr-Commit-Position: refs/heads/master@{#427966}

Powered by Google App Engine
This is Rietveld 408576698