Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: runtime/bin/secure_socket.cc

Issue 24539002: dart:io | Enable connection cache for secure networking clients. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/secure_socket.cc
diff --git a/runtime/bin/secure_socket.cc b/runtime/bin/secure_socket.cc
index 50382660853172b36605cc876bf6efc560764490..aa1cec2123c651a777f8a1dced65b6db8f60e08d 100644
--- a/runtime/bin/secure_socket.cc
+++ b/runtime/bin/secure_socket.cc
@@ -738,19 +738,8 @@ void SSLFilter::Connect(const char* host_name,
}
} else { // Client.
if (SSL_SetURL(filter_, host_name) == -1) {
- ThrowPRException("TlsException",
- "Failed SetURL call");
- }
-
- // This disables the SSL session cache for client connections.
- // This resolves issue 7208, but degrades performance.
- // TODO(7230): Reenable session cache, without breaking client connections.
- status = SSL_OptionSet(filter_, SSL_NO_CACHE, PR_TRUE);
- if (status != SECSuccess) {
- ThrowPRException("TlsException",
- "Failed SSL_OptionSet(NO_CACHE) call");
+ ThrowPRException("TlsException", "Failed SetURL call");
}
-
if (send_client_certificate) {
SSL_SetPKCS11PinArg(filter_, const_cast<char*>(password_));
status = SSL_GetClientAuthDataHook(

Powered by Google App Engine
This is Rietveld 408576698