Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2453873004: Simplify if condition in UDPSocket::RandomBind (Closed)

Created:
4 years, 1 month ago by hans
Modified:
4 years, 1 month ago
Reviewers:
agayev, gavinp
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify if condition in UDPSocket::RandomBind Found by PVS-Studio! BUG=660198 Committed: https://crrev.com/d235d4a00cabbb2e017450fb5e64302544e39d89 Cr-Commit-Position: refs/heads/master@{#428414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/udp/udp_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hans
Please take a look.
4 years, 1 month ago (2016-10-27 22:35:24 UTC) #2
gavinp
cute. lgtm.
4 years, 1 month ago (2016-10-28 16:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873004/1
4 years, 1 month ago (2016-10-28 16:38:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:47:46 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:53:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d235d4a00cabbb2e017450fb5e64302544e39d89
Cr-Commit-Position: refs/heads/master@{#428414}

Powered by Google App Engine
This is Rietveld 408576698