Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2453873003: Addressing C4267 for pdf. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Will Harris
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Addressing C4267 for pdf. BUG=167187 Committed: https://crrev.com/3d4b241f6376cd5a5b63d3100dad5079df5134c7 Cr-Commit-Position: refs/heads/master@{#427947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M components/pdf/renderer/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M pdf/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
4 years, 1 month ago (2016-10-27 02:54:03 UTC) #6
Will Harris
lgtm I love saying goodbye to warning suppressions.
4 years, 1 month ago (2016-10-27 04:56:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873003/1
4 years, 1 month ago (2016-10-27 05:14:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 05:20:07 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 05:23:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d4b241f6376cd5a5b63d3100dad5079df5134c7
Cr-Commit-Position: refs/heads/master@{#427947}

Powered by Google App Engine
This is Rietveld 408576698