Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2453873002: Add --output option to Swarming client and pass it through to the bot (Closed)

Created:
4 years, 1 month ago by aludwin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, KevinL, ryanmartens
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add --output option to Swarming client and pass it through to the bot BUG= Committed: https://github.com/luci/luci-py/commit/7daf7ab4d5021ab8880770de452377cb36f0c36a

Patch Set 1 #

Patch Set 2 : Fix help text for --output #

Total comments: 2

Patch Set 3 : Fix merge conflicts with 25f9f75 and 8ccc159 #

Patch Set 4 : Reponse to PS2 reviews #

Patch Set 5 : Rebase #

Patch Set 6 : Fix broken smoke test and rebase #

Patch Set 7 : Fix rebase mistake (unnecessary import) #

Patch Set 8 : Extra help text for examples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -14 lines) Patch
M appengine/swarming/handlers_bot.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/handlers_bot_test.py View 1 2 5 chunks +5 lines, -0 lines 0 comments Download
M appengine/swarming/handlers_endpoints_test.py View 7 chunks +9 lines, -2 lines 0 comments Download
M appengine/swarming/local_smoke_test.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/server/task_request.py View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download
M appengine/swarming/server/task_request_test.py View 1 2 6 chunks +6 lines, -3 lines 0 comments Download
M appengine/swarming/swarming_rpcs.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/test_env_handlers.py View 1 chunk +1 line, -0 lines 0 comments Download
M client/example/common.py View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M client/swarming.py View 1 2 3 4 chunks +9 lines, -2 lines 0 comments Download
M client/tests/swarming_test.py View 7 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 40 (19 generated)
aludwin
4 years, 1 month ago (2016-10-26 18:40:06 UTC) #2
M-A Ruel
+Kevin in practice we'll want to show them in the UI. The only blocker is ...
4 years, 1 month ago (2016-10-26 18:47:32 UTC) #4
aludwin
I manually confirmed the feature works on the latest PS
4 years, 1 month ago (2016-10-27 18:28:34 UTC) #5
M-A Ruel
lgtm
4 years, 1 month ago (2016-10-27 20:05:50 UTC) #6
aludwin
You can ignore this - just rebased
4 years, 1 month ago (2016-10-27 22:04:43 UTC) #7
aludwin
You can ignore this - just rebased
4 years, 1 month ago (2016-10-27 22:04:46 UTC) #8
M-A Ruel
lgtm
4 years, 1 month ago (2016-10-27 22:22:44 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2440353004 Patch 160001). Please resolve the dependency and ...
4 years, 1 month ago (2016-10-27 22:48:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873002/80001
4 years, 1 month ago (2016-10-27 22:59:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/322130639c4c6910)
4 years, 1 month ago (2016-10-27 23:06:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873002/100001
4 years, 1 month ago (2016-10-28 02:46:06 UTC) #19
aludwin
4 years, 1 month ago (2016-10-28 02:50:08 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873002/120001
4 years, 1 month ago (2016-10-28 02:50:26 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3222045a6d208410)
4 years, 1 month ago (2016-10-28 02:51:56 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873002/120001
4 years, 1 month ago (2016-10-28 02:54:36 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3222082c4330c810)
4 years, 1 month ago (2016-10-28 02:56:07 UTC) #30
aludwin
4 years, 1 month ago (2016-10-28 03:21:33 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873002/140001
4 years, 1 month ago (2016-10-28 03:21:53 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/322221237877a610)
4 years, 1 month ago (2016-10-28 03:23:23 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453873002/140001
4 years, 1 month ago (2016-10-28 16:50:51 UTC) #38
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:25:27 UTC) #40
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://github.com/luci/luci-py/commit/7daf7ab4d5021ab8880770de452377cb36f0c36a

Powered by Google App Engine
This is Rietveld 408576698