depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves

depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves

Note: This CL originally just removed a deprecated use of Remove use of DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since these are all deprecated and unused.

BUG=660453
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/136b49ff7e09d851bc677495a37bea1d87e102a7

[qyearsley, 2016-10-26 16:39:58]

qyearsley@chromium.org changed reviewers:
+ tandrii@chromium.org

[qyearsley, 2016-10-27 16:59:02]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 16:59:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 17:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:02:03]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-10-28 15:46:45]

Patchset #2 should be deleted, I think you've uploaded it a separate CL already.
PS#1 -> LG-TM % {
  file a bug for this, codesearch for any usage you can find and delete it
preemptively, send PSA with reference to bug and CL, add BUG= field to this CL
} 

I appreciate you taking time to do this, but my experience says we should PSA
people and having a bug for bug is very useful if there are >1 CLs (i hope not).

[tandrii(chromium), 2016-10-28 15:47:48]

Hey codesearch says the only refs are from depot_tools:
   https://cs.chromium.org/search/?q=DoGetTrySlaves&sq=package:chromium&type=cs
can you also remove those references?

On the bright side, this means we won't break chromium devs :))

[qyearsley, 2016-10-28 18:30:37]

Description was changed from

==========
git cl try: Remove use of deprecated method DoGetTrySlaves.

Context: Suggested in http://crrev.com/2442153002
==========

to

==========
depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves

Note: This CL originally just removed a deprecated use of Remove use of
DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to
remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since
these are all deprecated and unused.

BUG=660453
==========

[qyearsley, 2016-10-28 18:30:42]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:30:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:33:58]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-10-28 18:45:57]

On 2016/10/28 at 15:46:45, tandrii wrote:
> Patchset #2 should be deleted, I think you've uploaded it a separate CL
already.
> PS#1 -> LG-TM % {
>   file a bug for this, codesearch for any usage you can find and delete it
preemptively, send PSA with reference to bug and CL, add BUG= field to this CL
> } 
> 
> I appreciate you taking time to do this, but my experience says we should PSA
people and having a bug for bug is very useful if there are >1 CLs (i hope not).

Sounds good -- now updated this CL to to remove more related code, and filed a
bug and sent a PSA.

[tandrii(chromium), 2016-10-30 16:47:16]

LGTM && Thanks for doing this!

[qyearsley, 2016-10-31 15:59:15]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:59:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:02:29]

Description was changed from

==========
depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves

Note: This CL originally just removed a deprecated use of Remove use of
DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to
remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since
these are all deprecated and unused.

BUG=660453
==========

to

==========
depot_tools: Remove DoGetTrySlaves, GetTrySlavesExecuter, GetPreferredTrySlaves

Note: This CL originally just removed a deprecated use of Remove use of
DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to
remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since
these are all deprecated and unused.

BUG=660453

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/136b49ff7e09d8...
==========

[commit-bot: I haz the power, 2016-10-31 16:02:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/136b49ff7e09d8...

[qyearsley, 2016-10-31 16:05:44]

On 2016/10/30 at 16:47:16, tandrii wrote:
> LGTM && Thanks for doing this!

No problem :-)