Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2453813002: [Turbofan] Add USE for local used only by DCHECK. (Closed)

Created:
4 years, 1 month ago by bbudge
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add USE for local used only by DCHECK. LOG=N BUG=v8:4124 Committed: https://crrev.com/51bbfc7da258b21ecf448e7731bd8c2b89d3f43f Cr-Commit-Position: refs/heads/master@{#40603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/register-allocator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bbudge
4 years, 1 month ago (2016-10-26 17:18:23 UTC) #6
bbudge
Looking for quick review to green up the mips bot. https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4924/
4 years, 1 month ago (2016-10-26 17:25:34 UTC) #8
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-10-26 17:26:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453813002/1
4 years, 1 month ago (2016-10-26 17:26:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 17:28:34 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:14:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51bbfc7da258b21ecf448e7731bd8c2b89d3f43f
Cr-Commit-Position: refs/heads/master@{#40603}

Powered by Google App Engine
This is Rietveld 408576698