rAc: phone number cleanup

components/autofill/core/browser/phone_number_i18n.cc

Index: components/autofill/core/browser/phone_number_i18n.cc
diff --git a/components/autofill/core/browser/phone_number_i18n.cc b/components/autofill/core/browser/phone_number_i18n.cc
index 1cb49ca20b343e575a3ee6281b0d7491586aabb7..774fccae9c90ccc1e81a7d8834dd7f8a52314c9c 100644
--- a/components/autofill/core/browser/phone_number_i18n.cc
+++ b/components/autofill/core/browser/phone_number_i18n.cc
@@ -249,6 +249,23 @@ PhoneObject::PhoneObject(const base::string16& number,
   }
 }
 
+base::string16 FormatPhoneNumberForRegion(const base::string16& whole_number,
+                                          const std::string& region) {
+  PhoneNumber phone_number;
+  PhoneNumberUtil* phone_util = PhoneNumberUtil::GetInstance();
+  if (phone_util->Parse(UTF16ToUTF8(whole_number),
+                        region,
+                        &phone_number) != PhoneNumberUtil::NO_PARSING_ERROR) {
+    return base::string16();
+  }
+
+  std::string formatted_number;
+  phone_util->Format(phone_number,
+                     PhoneNumberUtil::PhoneNumberFormat::NATIONAL,
+                     &formatted_number);
+  return UTF8ToUTF16(formatted_number);
+}

[Ilya Sherman, 2013/09/26 22:01:06]

Please still move this above the PhoneObject constructor ;)

Though, it might be cleaner to just add a GetNationalFormattedNumber() method to
the PhoneObject class.

[Evan Stade, 2013/09/27 00:29:17]

Done.

+
 PhoneObject::PhoneObject(const PhoneObject& other) { *this = other; }
 
 PhoneObject::PhoneObject() {}