Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: tests/standalone/io/secure_server_client_certificate_test.dart

Issue 24538006: Split secure_server_client_certificate test in two, because of session cache. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add fix to web_socket_test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/io/secure_server_client_no_certificate_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/secure_server_client_certificate_test.dart
diff --git a/tests/standalone/io/secure_server_client_certificate_test.dart b/tests/standalone/io/secure_server_client_certificate_test.dart
index b2e385024bf365ba4098483dcba314915760ea7f..12d284da2b1a17fa9b3f20d0a194b66d9c86144f 100644
--- a/tests/standalone/io/secure_server_client_certificate_test.dart
+++ b/tests/standalone/io/secure_server_client_certificate_test.dart
@@ -12,8 +12,8 @@ import "package:path/path.dart";
const HOST_NAME = "localhost";
const CERTIFICATE = "localhost_cert";
-void testClientCertificate() {
- asyncStart();
+Future testClientCertificate() {
+ var completer = new Completer();
SecureServerSocket.bind(HOST_NAME,
0,
CERTIFICATE,
@@ -34,14 +34,15 @@ void testClientCertificate() {
clientEnd.close();
serverEnd.close();
server.close();
- asyncEnd();
+ completer.complete();
});
});
});
+ return completer.future;
}
-void testRequiredClientCertificate() {
- asyncStart();
+Future testRequiredClientCertificate() {
+ var completer = new Completer();
SecureServerSocket.bind(HOST_NAME,
0,
CERTIFICATE,
@@ -62,53 +63,11 @@ void testRequiredClientCertificate() {
clientEnd.close();
serverEnd.close();
server.close();
- asyncEnd();
- });
- });
- });
-}
-
-void testNoClientCertificate() {
- asyncStart();
- SecureServerSocket.bind(HOST_NAME,
- 0,
- CERTIFICATE,
- requestClientCertificate: true).then((server) {
- var clientEndFuture = SecureSocket.connect(HOST_NAME,
- server.port);
- server.listen((serverEnd) {
- X509Certificate certificate = serverEnd.peerCertificate;
- Expect.isNull(certificate);
- clientEndFuture.then((clientEnd) {
- clientEnd.close();
- serverEnd.close();
- server.close();
- asyncEnd();
- });
- });
- });
-}
-
-void testNoRequiredClientCertificate() {
- asyncStart();
- bool clientError = false;
- SecureServerSocket.bind(HOST_NAME,
- 0,
- CERTIFICATE,
- requireClientCertificate: true).then((server) {
- Future clientDone = SecureSocket.connect(HOST_NAME, server.port)
- .catchError((e) { clientError = true; });
- server.listen((serverEnd) {
- Expect.fail("Got a unverifiable connection");
- },
- onError: (e) {
- clientDone.then((_) {
- Expect.isTrue(clientError);
- server.close();
- asyncEnd();
+ completer.complete();
});
});
});
+ return completer.future;
}
void main() {
@@ -117,8 +76,8 @@ void main() {
password: 'dartdart',
useBuiltinRoots: false);
- testClientCertificate();
- testRequiredClientCertificate();
- testNoClientCertificate();
- testNoRequiredClientCertificate();
+ asyncStart();
+ testClientCertificate()
+ .then((_) => testRequiredClientCertificate())
+ .then((_) => asyncEnd());
}
« no previous file with comments | « no previous file | tests/standalone/io/secure_server_client_no_certificate_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698