[rac] Add libaddressinput dependency

DEPS

 # When adding a new dependency, please update the top-level .gitignore file
 # to list the dependency's destination directory.
 
 vars = {
   # Use this googlecode_url variable only if there is an internal mirror for it.
   # If you do not know, use the full path while defining your new deps entry.
   "googlecode_url": "http://%s.googlecode.com/svn",
   "sourceforge_url": "http://svn.code.sf.net/p/%(repo)s/code",
   "webkit_trunk": "http://src.chromium.org/blink/trunk",
   "nacl_trunk": "http://src.chromium.org/native_client/trunk",
   "webkit_revision": "158327",
   "chromium_git": "https://chromium.googlesource.com",
   "chromiumos_git": "https://chromium.googlesource.com/chromiumos",
   "skia_git": "https://skia.googlesource.com",
   "swig_revision": "69281",
   "nacl_revision": "12194",
   # After changing nacl_revision, run 'glient sync' and check native_client/DEPS
   # to update other nacl_*_revision's.
   "nacl_tools_revision": "11437",  # native_client/DEPS: tools_rev
   "gtm_revision": "616",
 
   "libphonenumber_revision": "584",
+  "libaddressinput_revision": "137",

[Evan Stade, 2013/09/26 02:08:10]

alphabetical order?

[please use gerrit instead, 2013/09/26 16:17:19]

The existing order doesn't seem to be alphabetical. Placing address validation
next to phone validation library seems most logical.

[Evan Stade, 2013/09/26 16:31:12]

this block of 3 (now 4) related libraries were alphabetical until you added this
one.

[please use gerrit instead, 2013/09/26 16:43:57]

Good point. Sorted.

   "libvpx_revision": "225010",
   "lss_revision": "24",
 
   # These two FFmpeg variables must be updated together.  One is used for SVN
   # checkouts and the other for Git checkouts.
   "ffmpeg_revision": "224426",
   "ffmpeg_hash": "5879ccd47e649bf2dfaec45f02ec5517bd3621d2",
 
   "sfntly_revision": "134",
   "lighttpd_revision": "33737",
@@ skipping 181 matching lines @@
     (Var("sourceforge_url") % {"repo": "jsoncpp"}) +
         "/trunk/jsoncpp/src/lib_json@" + Var("jsoncpp_revision"),
 
   "src/third_party/libyuv":
     (Var("googlecode_url") % "libyuv") + "/trunk@723",
 
   "src/third_party/smhasher/src":
     (Var("googlecode_url") % "smhasher") + "/trunk@149",
 
   "src/third_party/libphonenumber/src/phonenumbers":
      (Var("googlecode_url") % "libphonenumber") +

[Evan Stade, 2013/09/26 02:08:10]

do these lines have the wrong indent?

[please use gerrit instead, 2013/09/26 16:17:19]

Yes, these lines appear to have 3-space and 4-space indents. The rest of the
file uses 2-space indents.

[Evan Stade, 2013/09/26 16:31:12]

could you fix that?

[please use gerrit instead, 2013/09/26 16:43:57]

Fixed to be 2-space indents after : and 4-space indents after +, which matches
the rest of the DEPS file.

          "/trunk/cpp/src/phonenumbers@" + Var("libphonenumber_revision"),
   "src/third_party/libphonenumber/src/test":
      (Var("googlecode_url") % "libphonenumber") + "/trunk/cpp/test@" +
          Var("libphonenumber_revision"),
   "src/third_party/libphonenumber/src/resources":
      (Var("googlecode_url") % "libphonenumber") + "/trunk/resources@" +
          Var("libphonenumber_revision"),
 
+  # There's no internal mirror for libaddressinput, so not using
+  # 'googlecode_url' variable here.
+  "src/third_party/libaddressinput/testdata":
+    "http://libaddressinput.googlecode.com/svn/trunk/testdata@" +
+      Var("libaddressinput_revision"),
+
   "src/tools/deps2git":
     "/trunk/tools/deps2git@214390",
 
   "src/third_party/webpagereplay":
     (Var("googlecode_url") % "web-page-replay") + "/trunk@521",
 
   "src/third_party/pywebsocket/src":
     (Var("googlecode_url") % "pywebsocket") + "/trunk/src@662",
 
   "src/third_party/opus/src":
@@ skipping 103 matching lines @@
     "src/third_party/webgl_conformance": None,
     "src/third_party/ffmpeg": None,
     "src/third_party/hunspell_dictionaries": None,
     "src/third_party/hunspell": None,
     "src/third_party/leveldatabase/src": None,
     "src/third_party/libexif/sources": None,
     "src/third_party/libjpeg_turbo": None,
     "src/third_party/libphonenumber/src/phonenumbers": None,
     "src/third_party/libphonenumber/src/test": None,
     "src/third_party/libphonenumber/src/resources": None,
+    "src/third_party/libaddressinput/testdata": None,

[Evan Stade, 2013/09/26 02:08:10]

is there some specific order to this block? it seems vaguely alphabetical

[please use gerrit instead, 2013/09/26 16:17:19]

Not really alphabetical here, either, sorry. See the sequence below: first
"libsrtp", then "ursctp", and then "libvpx". 

[Evan Stade, 2013/09/26 16:31:12]

if you take out bidichecker, usrsctp and webgpl_conformance then I think the
entire block is alphabetical. Those three mistakes should be fixed rather than
exacerbated.

[please use gerrit instead, 2013/09/26 16:43:57]

Agreed. Sorted everything in this block.

     "src/third_party/libsrtp": None,
     "src/third_party/usrsctp/usrsctplib": None,
     "src/third_party/libvpx": None,
     "src/third_party/libyuv": None,
     "src/third_party/ots": None,
     "src/third_party/pylib": None,
     "src/third_party/pymox/src": None,
     "src/third_party/safe_browsing/testing": None,
     "src/third_party/scons-2.0.1": None,
     "src/third_party/sfntly/cpp/src": None,
@@ skipping 252 matching lines @@
     "pattern": ".",
     "action": ["python", "src/build/gyp_chromium"],
   },
   {
     # Check for landmines (reasons to clobber the build).
     "name": "landmines",
     "pattern": ".",
     "action": ["python", "src/build/landmines.py"],
   },
 ]