Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2453793002: Add disableStencil method to GrGLGpu (Closed)

Created:
4 years, 1 month ago by csmartdalton
Modified:
4 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add disableStencil method to GrGLGpu Most the calls to flushStencil were just trying to disable it. This change cleans up that code so it can just call "disableStencil" instead of having to muck with GrStencilSettings. It should also make those calls slightly faster. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2453793002 Committed: https://skia.googlesource.com/skia/+/c7d853343a42e28edd9c38a3308afaa846fce1bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -37 lines) Patch
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 5 chunks +30 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 1 month ago (2016-10-26 16:33:40 UTC) #3
bsalomon
lgtm
4 years, 1 month ago (2016-10-26 16:37:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453793002/1
4 years, 1 month ago (2016-10-26 16:53:13 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:13:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c7d853343a42e28edd9c38a3308afaa846fce1bc

Powered by Google App Engine
This is Rietveld 408576698