Alerting the user when the provided date for credit card is passed, not save the card, and not clos…

chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Autofill Settings tests. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 285 matching lines @@
             now.getFullYear().toString(),
             yearOptions[0].textContent.trim());
         assertEquals(
             maxYear.toString(),
             yearOptions[yearOptions.length -1].textContent.trim());
         assertEquals(
             creditCard.expirationYear, creditCardDialog.$.year.value);
       });
     });
 
+    test('verifySaveExpiredCreditCardEdit', function(done) {
+      var creditCard = FakeDataMaker.emptyCreditCardEntry();
+
+      var now = new Date();
+      creditCard.expirationYear = now.getFullYear();

[Moe, 2016/10/27 18:31:11]

Can you refactor your test to have a test for year too? both year and month
affect the expiry. You should test both.

[Parastoo, 2016/10/27 22:18:57]

Done.

+      creditCard.expirationMonth = now.getMonth() - 1;

[Mathieu, 2016/10/27 15:49:56]

If this test runs in January this will be -1?

[Parastoo, 2016/10/27 16:08:40]

Yes, and it's safe. I tested it. Is it OK to leave it as is? need a comment?

[Parastoo, 2016/10/27 22:18:57]

Done.

+
+      var creditCardDialog = self.createCreditCardDialog_(creditCard);
+
+      return test_util.whenAttributeIs(
+          creditCardDialog.$.dialog, 'open', true).then(function() {
+        creditCardDialog.addEventListener('save-credit-card', function() {
+          // Fail the test because the save event should not be called when
+          // the card is expired.
+          assertTrue(false);
+          done();

[Moe, 2016/10/27 18:31:11]

I don't think this last line will be even reached. the test should fail at the
assert.

[Parastoo, 2016/10/27 22:18:57]

Done.

+        });
+        creditCardDialog.addEventListener('tap', function() {
+          // Test is |done| in a timeout in order to ensure that
+          // 'save-credit-card' is NOT fired after this test.
+          window.setTimeout(done, 100);

[Mathieu, 2016/10/27 15:49:57]

is it possible to assert that the error shows?

[Parastoo, 2016/10/27 16:08:40]

I have to figure out how.

[Moe, 2016/10/27 18:31:11]

assertTrue(!!creditCardDialog.$$(...)) if you're using dom-if and
assertTrue(!!creditCardDialog.$$(...).clientHeight > 0) if you're using hidden
attr should work.

[Moe, 2016/10/27 18:35:08]

correction: assertTrue(creditCardDialog.$$(...).clientHeight > 0)
(no need for the bangs)

[Parastoo, 2016/10/27 22:18:57]

Done.

+        });
+
+        MockInteractions.tap(creditCardDialog.$.saveButton);
+      });
+    });
+
     // Test will timeout if event is not received.
     test('verifySaveCreditCardEdit', function(done) {
       var creditCard = FakeDataMaker.emptyCreditCardEntry();
       var creditCardDialog = self.createCreditCardDialog_(creditCard);
 
       return test_util.whenAttributeIs(
           creditCardDialog.$.dialog, 'open', true).then(function() {
         creditCardDialog.addEventListener('save-credit-card', function(event) {
           assertEquals(creditCard.guid, event.detail.guid);
           done();
@@ skipping 499 matching lines @@
           assertEquals(city, cols[0].value);
           assertEquals(state, cols[1].value);
           assertEquals(zip, cols[2].value);
         });
       });
     });
   });
 
   mocha.run();
 });