Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2453743002: The column balancer needs to look inside inlines. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The column balancer needs to look inside inlines. There may be floats there. Split traverseSubtree() into traverseLines() and traverseChildren(), so that traverseChildren() can easily be called directly when at inlines. BUG=586956 Committed: https://crrev.com/ebffb77d55b34e6d796a6ad4b7bf64063f6a1ef5 Cr-Commit-Position: refs/heads/master@{#427724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/balance-float-in-inline.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 1 chunk +30 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-26 16:03:48 UTC) #6
eae
There may be dragons. LGTM
4 years, 1 month ago (2016-10-26 16:52:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453743002/1
4 years, 1 month ago (2016-10-26 16:54:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 17:06:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:50:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebffb77d55b34e6d796a6ad4b7bf64063f6a1ef5
Cr-Commit-Position: refs/heads/master@{#427724}

Powered by Google App Engine
This is Rietveld 408576698