Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2453723002: Convert editing/style/toggle-style-bold-italic-mixed-editability.html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/toggle-style-bold-italic-mixed-editability.html to utilize w3c test harness This patch converts "toggle-style-bold-italic-mixed-editability.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior chagnes Committed: https://crrev.com/7282895adefdb62c5724b4e76e65db701ddc532f Cr-Commit-Position: refs/heads/master@{#427931}

Patch Set 1 : 2016-10-26T18:09:23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -79 lines) Patch
M third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability.html View 1 chunk +75 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic-mixed-editability-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL Since I don't see differences among platform, this test script checks only on current ...
4 years, 1 month ago (2016-10-26 09:46:02 UTC) #5
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-27 02:01:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453723002/1
4 years, 1 month ago (2016-10-27 04:01:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 04:06:16 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 04:08:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7282895adefdb62c5724b4e76e65db701ddc532f
Cr-Commit-Position: refs/heads/master@{#427931}

Powered by Google App Engine
This is Rietveld 408576698