Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2453693002: Analyze priority files first. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +34 lines, -8 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 1 month ago (2016-10-26 04:44:28 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as fcce68e2dfdb8b9942d04431c381bce95444b723 (presubmit successful).
4 years, 1 month ago (2016-10-26 04:44:54 UTC) #3
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-10-26 08:16:54 UTC) #4
Paul Berry
https://codereview.chromium.org/2453693002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2453693002/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode240 pkg/analyzer/lib/src/dart/analysis/driver.dart:240: break; Do need to set `analyzed = true` here? ...
4 years, 1 month ago (2016-10-31 16:51:40 UTC) #5
scheglov
4 years, 1 month ago (2016-10-31 17:38:52 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2453693002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2453693002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:240: break;
On 2016/10/31 16:51:40, Paul Berry wrote:
> Do need to set `analyzed = true` here?  Otherwise it looks like the code below
> (lines 245 and 246) will be unreachable.

Yes, you are right, we need to set `analyzed = true`.
I noticed and fixed this later in one of the CLs.

Powered by Google App Engine
This is Rietveld 408576698