third_party/WebKit/Source/devtools/scripts/compile_frontend.py - Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/compile_frontend.py

Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/scripts/compile_frontend.py

diff --git a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py b/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

index 9f6e5ca0ad733d779b21d329186245d70650b4ad..d6d2c393f28ea827c11dbc7f6ce65b52dc0c22af 100755

--- a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

+++ b/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

@@ -335,8 +335,7 @@ def dump_module(name, recursively, processed_modules):

command += module_arg(name) + ':'

filtered_scripts = descriptors.module_compiled_files(name)

filtered_scripts = [path.join(devtools_frontend_path, name, script) for script in filtered_scripts]

- # TODO(dgozman): move to separate module

- if name == 'sdk':

+ if name == 'protocol':

filtered_scripts.append(protocol_externs_file)

command += str(len(filtered_scripts))

first_dependency = True