Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Connections.js

Issue 2453673002: [DevTools] Scope common protocol infrastructure under Protocol namespace in a separate module. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js b/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
index d8e4d00c2ad61e0eb9b8c83a29d56cc10e2f4910..cca4df2400eaa1bd667694616be4a5c96ea77bdf 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Connections.js
@@ -4,8 +4,8 @@
/**
* @constructor
- * @implements {InspectorBackendClass.Connection}
- * @param {!InspectorBackendClass.Connection.Params} params
+ * @implements {Protocol.Connection}
+ * @param {!Protocol.Connection.Params} params
*/
WebInspector.MainConnection = function(params)
{
@@ -82,7 +82,7 @@ WebInspector.MainConnection.prototype = {
}
}
- InspectorBackendClass.deprecatedRunAfterPendingDispatches(invokeMethod);
+ Protocol.deprecatedRunAfterPendingDispatches(invokeMethod);
},
/**
@@ -109,9 +109,9 @@ WebInspector.MainConnection.prototype = {
/**
* @constructor
- * @implements {InspectorBackendClass.Connection}
+ * @implements {Protocol.Connection}
* @param {string} url
- * @param {!InspectorBackendClass.Connection.Params} params
+ * @param {!Protocol.Connection.Params} params
*/
WebInspector.WebSocketConnection = function(url, params)
{
@@ -179,8 +179,8 @@ WebInspector.WebSocketConnection.prototype = {
/**
* @constructor
- * @implements {InspectorBackendClass.Connection}
- * @param {!InspectorBackendClass.Connection.Params} params
+ * @implements {Protocol.Connection}
+ * @param {!Protocol.Connection.Params} params
*/
WebInspector.StubConnection = function(params)
{
@@ -204,7 +204,7 @@ WebInspector.StubConnection.prototype = {
_respondWithError: function(message)
{
var messageObject = JSON.parse(message);
- var error = { message: "This is a stub connection, can't dispatch message.", code: InspectorBackendClass.DevToolsStubErrorCode, data: messageObject };
+ var error = { message: "This is a stub connection, can't dispatch message.", code: Protocol.StubErrorCode, data: messageObject };
this._onMessage.call(null, { id: messageObject.id, error: error });
},

Powered by Google App Engine
This is Rietveld 408576698