Remove apply_gerrit_ref from bot_update recipe API

Remove apply_gerrit_ref from bot_update recipe API

BUG=skia:5588
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d918da642702b894af14c6ed6acf6a546970419c

[borenet, 2016-10-27 15:08:31]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@chromium.org, tandrii@chromium.org

[rmistry, 2016-10-27 15:09:52]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-10-27 15:09:52]

lgtm

[tandrii(chromium), 2016-10-27 15:15:07]

not lgtm. Sadly, ios internal is now using this :(

[tandrii(chromium), 2016-10-27 15:15:29]

but thanks for upgrading to bot_update.

[rmistry, 2016-10-27 15:15:52]

On 2016/10/27 15:15:07, tandrii(chromium) wrote:
> not lgtm. Sadly, ios internal is now using this :(

nooooooo

[borenet, 2016-10-27 15:16:17]

On 2016/10/27 15:15:52, rmistry wrote:
> On 2016/10/27 15:15:07, tandrii(chromium) wrote:
> > not lgtm. Sadly, ios internal is now using this :(
> 
> nooooooo

:(

[tandrii(chromium), 2016-10-27 15:20:28]

On 2016/10/27 15:16:17, borenet wrote:
> On 2016/10/27 15:15:52, rmistry wrote:
> > On 2016/10/27 15:15:07, tandrii(chromium) wrote:
> > > not lgtm. Sadly, ios internal is now using this :(
> > 
> > nooooooo
> 
> :(

Yeah. Can you remove skia's TODO and change it to:

TODO(tandrii): refactor this into tryserver.maybe_apply_patch

[borenet, 2016-10-28 14:55:08]

Description was changed from

==========
Remove apply_gerrit_ref from bot_update recipe API

BUG=skia:5588
==========

to

==========
Remove apply_gerrit_ref from bot_update recipe API

BUG=skia:5588
==========

[borenet, 2016-10-28 14:57:37]

On 2016/10/27 15:20:28, tandrii(chromium) wrote:
> On 2016/10/27 15:16:17, borenet wrote:
> > On 2016/10/27 15:15:52, rmistry wrote:
> > > On 2016/10/27 15:15:07, tandrii(chromium) wrote:
> > > > not lgtm. Sadly, ios internal is now using this :(
> > > 
> > > nooooooo
> > 
> > :(
> 
> Yeah. Can you remove skia's TODO and change it to:
> 
> TODO(tandrii): refactor this into tryserver.maybe_apply_patch

Done in patch set 2.

[tandrii(chromium), 2016-10-28 15:07:03]

LGTM, thanks!

[borenet, 2016-10-28 15:07:51]

The CQ bit was checked by borenet@google.com

[borenet, 2016-10-28 15:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2453663004/#ps20001
(title: "Comment")

[commit-bot: I haz the power, 2016-10-28 15:08:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 15:11:00]

Description was changed from

==========
Remove apply_gerrit_ref from bot_update recipe API

BUG=skia:5588
==========

to

==========
Remove apply_gerrit_ref from bot_update recipe API

BUG=skia:5588

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d918da642702b8...
==========

[commit-bot: I haz the power, 2016-10-28 15:11:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d918da642702b8...