Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2453653003: Fix some mojo dependencies in blink (Closed)

Created:
4 years, 1 month ago by tsniatowski
Modified:
4 years, 1 month ago
CC:
awdf+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, haraken, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, Peter Beverloo, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some mojo dependencies in blink Several places in blink were using mojo headers without a dependency on mojo targets that generate said headers, causing build flakiness. BUG=655123 Committed: https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc Cr-Commit-Position: refs/heads/master@{#427659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
tsniatowski
On 2016/10/26 08:40:19, tsniatowski wrote: > mailto:tsniatowski@opera.com changed reviewers: > + mailto:mvanouwerkerk@chromium.org PTAL
4 years, 1 month ago (2016-10-26 08:40:50 UTC) #3
Michael van Ouwerkerk
lgtm
4 years, 1 month ago (2016-10-26 08:52:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453653003/1
4 years, 1 month ago (2016-10-26 08:54:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/289752)
4 years, 1 month ago (2016-10-26 09:02:55 UTC) #10
tsniatowski
On 2016/10/26 09:02:55, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-10-26 09:43:01 UTC) #12
haraken
On 2016/10/26 09:43:01, tsniatowski wrote: > On 2016/10/26 09:02:55, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-10-26 09:47:01 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-10-26 09:47:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453653003/1
4 years, 1 month ago (2016-10-26 09:48:03 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 10:27:08 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 10:28:47 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc
Cr-Commit-Position: refs/heads/master@{#427659}

Powered by Google App Engine
This is Rietveld 408576698