Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: net/nqe/network_quality_observation_source.h

Issue 2453653002: Separate out observation sources as either HTTP layer or transport layer (Closed)
Patch Set: Addressed bengr comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/nqe/network_quality_estimator_unittest.cc ('k') | net/nqe/observation_buffer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_NQE_NETWORK_QUALITY_OBSERVATION_SOURCE_H_ 5 #ifndef NET_NQE_NETWORK_QUALITY_OBSERVATION_SOURCE_H_
6 #define NET_NQE_NETWORK_QUALITY_OBSERVATION_SOURCE_H_ 6 #define NET_NQE_NETWORK_QUALITY_OBSERVATION_SOURCE_H_
7 7
8 namespace net { 8 namespace net {
9 9
10 // On Android, a Java counterpart will be generated for this enum. 10 // On Android, a Java counterpart will be generated for this enum.
11 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net 11 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
12 // GENERATED_JAVA_CLASS_NAME_OVERRIDE: NetworkQualityObservationSource 12 // GENERATED_JAVA_CLASS_NAME_OVERRIDE: NetworkQualityObservationSource
13 // GENERATED_JAVA_PREFIX_TO_STRIP: NETWORK_QUALITY_OBSERVATION_SOURCE_ 13 // GENERATED_JAVA_PREFIX_TO_STRIP: NETWORK_QUALITY_OBSERVATION_SOURCE_
14 enum NetworkQualityObservationSource { 14 enum NetworkQualityObservationSource {
15 // The observation was taken at the request layer, e.g., a round trip time 15 // The observation was taken at the request layer, e.g., a round trip time
16 // is recorded as the time between the request being sent and the first byte 16 // is recorded as the time between the request being sent and the first byte
17 // being received. 17 // being received.
18 NETWORK_QUALITY_OBSERVATION_SOURCE_URL_REQUEST = 0, 18 NETWORK_QUALITY_OBSERVATION_SOURCE_HTTP = 0,
19 19
20 // The observation is taken from TCP statistics maintained by the kernel. 20 // The observation is taken from TCP statistics maintained by the kernel.
21 NETWORK_QUALITY_OBSERVATION_SOURCE_TCP, 21 NETWORK_QUALITY_OBSERVATION_SOURCE_TCP = 1,
22 22
23 // The observation is taken at the QUIC layer. 23 // The observation is taken at the QUIC layer.
24 NETWORK_QUALITY_OBSERVATION_SOURCE_QUIC, 24 NETWORK_QUALITY_OBSERVATION_SOURCE_QUIC = 2,
25 25
26 // The observation is a previously cached estimate of the metric. 26 // The observation is a previously cached estimate of the metric. The metric
27 NETWORK_QUALITY_OBSERVATION_SOURCE_CACHED_ESTIMATE, 27 // was computed at the HTTP layer.
28 NETWORK_QUALITY_OBSERVATION_SOURCE_HTTP_CACHED_ESTIMATE = 3,
28 29
29 // The observation is derived from network connection information provided 30 // The observation is derived from network connection information provided
30 // by the platform. For example, typical RTT and throughput values are used 31 // by the platform. For example, typical RTT and throughput values are used
31 // for a given type of network connection. 32 // for a given type of network connection. The metric was provided for use
32 NETWORK_QUALITY_OBSERVATION_SOURCE_DEFAULT_FROM_PLATFORM, 33 // at the HTTP layer.
34 NETWORK_QUALITY_OBSERVATION_SOURCE_DEFAULT_HTTP_FROM_PLATFORM = 4,
33 35
34 // The observation came from a Chromium-external source. 36 // The observation came from a Chromium-external source. The metric was
35 NETWORK_QUALITY_OBSERVATION_SOURCE_EXTERNAL_ESTIMATE, 37 // computed by the external source at the HTTP layer.
38 NETWORK_QUALITY_OBSERVATION_SOURCE_HTTP_EXTERNAL_ESTIMATE = 5,
39
40 // The observation is a previously cached estimate of the metric. The metric
41 // was computed at the transport layer.
42 NETWORK_QUALITY_OBSERVATION_SOURCE_TRANSPORT_CACHED_ESTIMATE = 6,
43
44 // The observation is derived from the network connection information provided
45 // by the platform. For example, typical RTT and throughput values are used
46 // for a given type of network connection. The metric was provided for use
47 // at the transport layer.
48 NETWORK_QUALITY_OBSERVATION_SOURCE_DEFAULT_TRANSPORT_FROM_PLATFORM = 7,
36 49
37 NETWORK_QUALITY_OBSERVATION_SOURCE_MAX, 50 NETWORK_QUALITY_OBSERVATION_SOURCE_MAX,
38 }; 51 };
39 52
40 } // namespace net 53 } // namespace net
41 54
42 #endif // NET_NQE_NETWORK_QUALITY_OBSERVATION_SOURCE_H_ 55 #endif // NET_NQE_NETWORK_QUALITY_OBSERVATION_SOURCE_H_
OLDNEW
« no previous file with comments | « net/nqe/network_quality_estimator_unittest.cc ('k') | net/nqe/observation_buffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698