Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: content/browser/download/download_item_impl.h

Issue 2453633006: [downloads] Move platform specific code out of DownloadTargetDeterminer. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 86f9f43220a94c243d22459f02d7ab7e20e46f99..8e138b120addaf610416d76aa56a761083eca801 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -9,6 +9,7 @@
#include <memory>
#include <string>
+#include <vector>
#include "base/callback_forward.h"
#include "base/files/file_path.h"
@@ -423,11 +424,14 @@ class CONTENT_EXPORT DownloadItemImpl
const base::FilePath& target_path,
TargetDisposition disposition,
DownloadDangerType danger_type,
- const base::FilePath& intermediate_path);
+ const base::FilePath& intermediate_path,
+ DownloadInterruptReason interrupt_reason);
void OnDownloadRenamedToIntermediateName(
DownloadInterruptReason reason, const base::FilePath& full_path);
+ void OnTargetResolved();
+
// If all pre-requisites have been met, complete download processing, i.e. do
// internal cleanup, file rename, and potentially auto-open. (Dangerous
// downloads still may block on user acceptance after this point.)
@@ -632,10 +636,11 @@ class CONTENT_EXPORT DownloadItemImpl
// Did the delegate delay calling Complete on this download?
bool delegate_delayed_complete_ = false;
- // Error return from DestinationError. Stored separately from
- // last_reason_ so that we can avoid handling destination errors until
- // after file name determination has occurred.
- DownloadInterruptReason destination_error_ = DOWNLOAD_INTERRUPT_REASON_NONE;
+ // Error return from DestinationError or received at Start(). Stored
+ // separately from last_reason_ so that we can avoid handling destination
+ // errors until after file name determination has occurred.
+ DownloadInterruptReason deferred_interrupt_reason_ =
+ DOWNLOAD_INTERRUPT_REASON_NONE;
// The following fields describe the current state of the download file.
« no previous file with comments | « chromecast/browser/cast_download_manager_delegate.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698