Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chrome/browser/download/download_target_info.h

Issue 2453633006: [downloads] Move platform specific code out of DownloadTargetDeterminer. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_target_info.h
diff --git a/chrome/browser/download/download_target_info.h b/chrome/browser/download/download_target_info.h
index f82d6b0420cdf108143ba9cf5abcaf2ad73b5a3a..6e3a49208eef3503729a99095e75f16ccee36fe8 100644
--- a/chrome/browser/download/download_target_info.h
+++ b/chrome/browser/download/download_target_info.h
@@ -5,9 +5,12 @@
#ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TARGET_INFO_H_
#define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TARGET_INFO_H_
+#include <string>
+
#include "base/files/file_path.h"
#include "chrome/common/safe_browsing/download_file_types.pb.h"
#include "content/public/browser/download_danger_type.h"
+#include "content/public/browser/download_interrupt_reasons.h"
#include "content/public/browser/download_item.h"
struct DownloadTargetInfo {
@@ -22,6 +25,8 @@ struct DownloadTargetInfo {
// Disposition. This will be TARGET_DISPOSITION_PROMPT if the user was
// prompted during the process of determining the download target. Otherwise
// it will be TARGET_DISPOSITION_OVERWRITE.
+ // TODO(asanka): This should be has_user_confirmation or somesuch that
+ // indicates that the user has seen and confirmed the download path.
content::DownloadItem::TargetDisposition target_disposition;
// Danger type of the download.
@@ -69,6 +74,9 @@ struct DownloadTargetInfo {
// opens should be handled. The file is considered to be handled safely if the
// filetype is supported by the renderer or a sandboxed plugin.
bool is_filetype_handled_safely;
+
+ // Result of the download target determination.
+ content::DownloadInterruptReason result;
};
#endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TARGET_INFO_H_
« no previous file with comments | « chrome/browser/download/download_target_determiner_unittest.cc ('k') | chrome/browser/download/download_target_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698