chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java - Issue 2453623003: Decouple MediaSession messages from WebContents (full patch)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

Issue 2453623003: Decouple MediaSession messages from WebContents (full patch) (Closed)

Patch Set: nit Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java ('k') | chromecast/browser/cast_media_blocker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

index 2720de1e540665438bfceda326ea41156bdd8ae9..bb900f21d1ebf55d6e79da7ed9c801fdd376730a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

@@ -24,7 +24,8 @@ import org.chromium.chrome.test.util.browser.TabTitleObserver;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.JavaScriptUtils;

-import org.chromium.content_public.browser.WebContentsObserver;

+import org.chromium.content_public.browser.MediaSession;

+import org.chromium.content_public.browser.MediaSessionObserver;

import org.chromium.content_public.common.MediaMetadata;

/**

@@ -150,8 +151,9 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- ObserverList.RewindableIterator<WebContentsObserver> observers =

- tab.getWebContents().getObserversForTesting();

+ ObserverList.RewindableIterator<MediaSessionObserver> observers =

+ MediaSession.fromWebContents(tab.getWebContents())

+ .getObserversForTesting();

while (observers.hasNext()) {

observers.next().mediaSessionStateChanged(isControllable, isSuspended);

}

@@ -163,8 +165,8 @@ public class NotificationTitleUpdatedTest extends ChromeActivityTestCaseBase<Chr