tests/standalone/io/https_bad_certificate_client.dart - Issue 24536005: Recommit "Change two secure networking tests". Add suppression to status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/https_bad_certificate_client.dart

Issue 24536005: Recommit "Change two secure networking tests". Add suppression to status file. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change flaky bad_certificate_test to Pass, Timeout. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/standalone/io/https_bad_certificate_client.dart

diff --git a/tests/standalone/io/https_bad_certificate_client.dart b/tests/standalone/io/https_bad_certificate_client.dart

index 4fe59a95b61d939b050ff698ad7943cd22d3eefc..4028ebc33feedf277769c5f3c9449a38452007fe 100644

--- a/tests/standalone/io/https_bad_certificate_client.dart

+++ b/tests/standalone/io/https_bad_certificate_client.dart

@@ -62,7 +62,7 @@ Future runHttpClient(int port, result) {

client.badCertificateCallback = null;

testFutures.add(client.getUrl(Uri.parse('https://$HOST_NAME:$port/$result'))

.then((HttpClientRequest request) {

- expect(false);

+ expect(result == 'true'); // The session cache may keep the last connection.

kasperl 2013/09/26 08:25:39 Long line.

}, onError: (e) {

expect(e is HandshakeException || e is SocketException);

}));

« no previous file with comments | « no previous file | tests/standalone/io/secure_multiple_client_server_test.dart » ('j') | tests/standalone/standalone.status » ('J')