Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2453583002:
win: Remove workaround for clang-cl that's no longer necessary. (Closed)
Descriptionwin: Remove workaround for clang-cl that's no longer necessary.
clang-cl now understands enough of `#pragma intrinsic` that it's no longer
necessary to explicitly include intrin.h to use SecureZeroMemory().
Reverts https://codereview.chromium.org/2070533002
BUG=chromium:592745
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/bba323f75e3d20d2d496a1986f91fc81b624affa
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
thakis@chromium.org changed reviewers: + mcgrathr@chromium.org
Hm, red bots 'cause nacl doesn't have https://codereview.chromium.org/2443963002/ yet (which is the roll that makes this workaround unnecessary). Do I just wait for that to be picked up?
On 2016/10/25 21:06:28, Nico wrote: > Hm, red bots 'cause nacl doesn't have > https://codereview.chromium.org/2443963002/ yet (which is the roll that makes > this workaround unnecessary). Do I just wait for that to be picked up? That's only done manually, and nothing in native_client seems to get done today without asking someone specifically. I've done a couple of these since I left the group and I could again, but Brad should assign someone from his team (or at least someone who still works on Chrome at all! ;-) to do this regularly, or finally automate it properly.
On 2016/10/25 23:11:59, Roland McGrath wrote: > On 2016/10/25 21:06:28, Nico wrote: > > Hm, red bots 'cause nacl doesn't have > > https://codereview.chromium.org/2443963002/ yet (which is the roll that makes > > this workaround unnecessary). Do I just wait for that to be picked up? > > That's only done manually, and nothing in native_client seems to get done today > without asking someone specifically. > I've done a couple of these since I left the group and I could again, but Brad > should assign someone from his team (or at least someone who still works on > Chrome at all! ;-) to do this regularly, or finally automate it properly. If you could do this or poke Bad to find someone to do this, that'd be very appreciated :-)
mcgrathr@chromium.org changed reviewers: + bradnelson@chromium.org, sbc@chromium.org
This needs another update of "chrome_rev" and everything related in native_client/DEPS. Brad/Sam, I'm done swooping in to do these for you guys. It really should be automated, but short of that, someone who is actually on the team (still) needs to be on the hook for doing these regularly.
On 2016/10/27 22:55:06, Roland McGrath wrote: > This needs another update of "chrome_rev" and everything related in > native_client/DEPS. > > Brad/Sam, I'm done swooping in to do these for you guys. It really should be > automated, but short of that, someone who is actually on the team (still) needs > to be on the hook for doing these regularly. Thanks Roland. Brad or I will take care of it. I opened an issue: https://bugs.chromium.org/p/nativeclient/issues/detail?id=4381
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/28 00:16:16, Sam Clegg wrote: > On 2016/10/27 22:55:06, Roland McGrath wrote: > > This needs another update of "chrome_rev" and everything related in > > native_client/DEPS. > > > > Brad/Sam, I'm done swooping in to do these for you guys. It really should be > > automated, but short of that, someone who is actually on the team (still) > needs > > to be on the hook for doing these regularly. > > Thanks Roland. Brad or I will take care of it. I opened an issue: > https://bugs.chromium.org/p/nativeclient/issues/detail?id=4381 This looks it can land now.
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-nacl-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by sbc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== win: Remove workaround for clang-cl that's no longer necessary. clang-cl now understands enough of `#pragma intrinsic` that it's no longer necessary to explicitly include intrin.h to use SecureZeroMemory(). Reverts https://codereview.chromium.org/2070533002 BUG=chromium:592745 ========== to ========== win: Remove workaround for clang-cl that's no longer necessary. clang-cl now understands enough of `#pragma intrinsic` that it's no longer necessary to explicitly include intrin.h to use SecureZeroMemory(). Reverts https://codereview.chromium.org/2070533002 BUG=chromium:592745 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/bba323f75... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/native_client/src/native_client/+/bba323f75... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
