Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5295)

Unified Diff: cc/input/scrollbar_animation_controller.h

Issue 2453553003: Disable overlay scrollbars in Blink when hidden by the compositor. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/scrollbar_animation_controller.h
diff --git a/cc/input/scrollbar_animation_controller.h b/cc/input/scrollbar_animation_controller.h
index 7bb421f4946bf9d18251f64fbf31c61cf084a050..9d6ab6a37f55e7509213c29cff4c4d0c66a61265 100644
--- a/cc/input/scrollbar_animation_controller.h
+++ b/cc/input/scrollbar_animation_controller.h
@@ -24,6 +24,7 @@ class CC_EXPORT ScrollbarAnimationControllerClient {
virtual void SetNeedsRedrawForScrollbarAnimation() = 0;
virtual void SetNeedsAnimateForScrollbarAnimation() = 0;
virtual ScrollbarSet ScrollbarsFor(int scroll_layer_id) const = 0;
+ virtual void SetScrollbarsHidden(int layer_id, bool hidden) = 0;
protected:
virtual ~ScrollbarAnimationControllerClient() {}
@@ -63,6 +64,8 @@ class CC_EXPORT ScrollbarAnimationController {
void PostDelayedAnimationTask(bool on_resize);
+ int scroll_layer_id_;
aelias_OOO_until_Jul13 2016/10/26 19:01:03 Please leave this private and introduce a protecte
bokan 2016/10/27 20:56:46 Done.
+
private:
// Returns how far through the animation we are as a progress value from
// 0 to 1.
@@ -74,7 +77,6 @@ class CC_EXPORT ScrollbarAnimationController {
bool is_animating_;
- int scroll_layer_id_;
bool currently_scrolling_;
bool scroll_gesture_has_scrolled_;
base::CancelableClosure delayed_scrollbar_fade_;
« no previous file with comments | « no previous file | cc/input/scrollbar_animation_controller.cc » ('j') | cc/input/scrollbar_animation_controller_thinning.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698