Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2453553003: Disable overlay scrollbars in Blink when hidden by the compositor. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 // post-update work even if the scroll position didn't change. 314 // post-update work even if the scroll position didn't change.
315 void setScrollPositionUnconditionally(const DoublePoint&, 315 void setScrollPositionUnconditionally(const DoublePoint&,
316 ScrollType = ProgrammaticScroll); 316 ScrollType = ProgrammaticScroll);
317 317
318 // TODO(szager): Actually run these after all of layout is finished. 318 // TODO(szager): Actually run these after all of layout is finished.
319 // Currently, they run at the end of box()'es layout (or after all flexbox 319 // Currently, they run at the end of box()'es layout (or after all flexbox
320 // layout has finished) but while document layout is still happening. 320 // layout has finished) but while document layout is still happening.
321 void updateAfterLayout(); 321 void updateAfterLayout();
322 void clampScrollOffsetsAfterLayout(); 322 void clampScrollOffsetsAfterLayout();
323 323
324 void didChangeScrollbarsHidden() override;
325
324 void updateAfterStyleChange(const ComputedStyle*); 326 void updateAfterStyleChange(const ComputedStyle*);
325 void updateAfterOverflowRecalc(); 327 void updateAfterOverflowRecalc();
326 328
327 bool updateAfterCompositingChange() override; 329 bool updateAfterCompositingChange() override;
328 330
329 bool hasScrollbar() const { 331 bool hasScrollbar() const {
330 return hasHorizontalScrollbar() || hasVerticalScrollbar(); 332 return hasHorizontalScrollbar() || hasVerticalScrollbar();
331 } 333 }
332 bool hasOverflowControls() const { 334 bool hasOverflowControls() const {
333 return hasScrollbar() || scrollCorner() || resizer(); 335 return hasScrollbar() || scrollCorner() || resizer();
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 void invalidateStickyConstraintsFor(PaintLayer*, 470 void invalidateStickyConstraintsFor(PaintLayer*,
469 bool needsCompositingUpdate = true); 471 bool needsCompositingUpdate = true);
470 472
471 uint64_t id() const; 473 uint64_t id() const;
472 474
473 DECLARE_VIRTUAL_TRACE(); 475 DECLARE_VIRTUAL_TRACE();
474 476
475 private: 477 private:
476 explicit PaintLayerScrollableArea(PaintLayer&); 478 explicit PaintLayerScrollableArea(PaintLayer&);
477 479
480 void updateScrollbarsEnabledState();
481
478 bool hasHorizontalOverflow() const; 482 bool hasHorizontalOverflow() const;
479 bool hasVerticalOverflow() const; 483 bool hasVerticalOverflow() const;
480 bool hasScrollableHorizontalOverflow() const; 484 bool hasScrollableHorizontalOverflow() const;
481 bool hasScrollableVerticalOverflow() const; 485 bool hasScrollableVerticalOverflow() const;
482 bool visualViewportSuppliesScrollbars() const; 486 bool visualViewportSuppliesScrollbars() const;
483 487
484 bool needsScrollbarReconstruction() const; 488 bool needsScrollbarReconstruction() const;
485 489
486 void updateScrollOrigin(); 490 void updateScrollOrigin();
487 void updateScrollDimensions(); 491 void updateScrollDimensions();
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 581
578 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 582 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
579 ScrollableArea, 583 ScrollableArea,
580 scrollableArea, 584 scrollableArea,
581 scrollableArea->isPaintLayerScrollableArea(), 585 scrollableArea->isPaintLayerScrollableArea(),
582 scrollableArea.isPaintLayerScrollableArea()); 586 scrollableArea.isPaintLayerScrollableArea());
583 587
584 } // namespace blink 588 } // namespace blink
585 589
586 #endif // LayerScrollableArea_h 590 #endif // LayerScrollableArea_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698