Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2453553003: Disable overlay scrollbars in Blink when hidden by the compositor. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 // animations. 245 // animations.
246 virtual bool scheduleAnimation(); 246 virtual bool scheduleAnimation();
247 virtual void serviceScrollAnimations(double monotonicTime); 247 virtual void serviceScrollAnimations(double monotonicTime);
248 virtual void updateCompositorScrollAnimations(); 248 virtual void updateCompositorScrollAnimations();
249 virtual void registerForAnimation() {} 249 virtual void registerForAnimation() {}
250 virtual void deregisterForAnimation() {} 250 virtual void deregisterForAnimation() {}
251 251
252 virtual bool usesCompositedScrolling() const { return false; } 252 virtual bool usesCompositedScrolling() const { return false; }
253 virtual bool shouldScrollOnMainThread() const; 253 virtual bool shouldScrollOnMainThread() const;
254 254
255 // Overlay scrollbars can "fade-out" when inactive.
256 virtual bool scrollbarsHidden() const;
257 virtual void setScrollbarsHidden(bool);
258 virtual void didChangeScrollbarsHidden(){};
259
255 // Returns true if the GraphicsLayer tree needs to be rebuilt. 260 // Returns true if the GraphicsLayer tree needs to be rebuilt.
256 virtual bool updateAfterCompositingChange() { return false; } 261 virtual bool updateAfterCompositingChange() { return false; }
257 262
258 virtual bool userInputScrollable(ScrollbarOrientation) const = 0; 263 virtual bool userInputScrollable(ScrollbarOrientation) const = 0;
259 virtual bool shouldPlaceVerticalScrollbarOnLeft() const = 0; 264 virtual bool shouldPlaceVerticalScrollbarOnLeft() const = 0;
260 265
261 // Convenience functions 266 // Convenience functions
262 float scrollOffset(ScrollbarOrientation orientation) { 267 float scrollOffset(ScrollbarOrientation orientation) {
263 return orientation == HorizontalScrollbar ? scrollOffsetInt().width() 268 return orientation == HorizontalScrollbar ? scrollOffsetInt().width()
264 : scrollOffsetInt().height(); 269 : scrollOffsetInt().height();
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 mutable Member<ScrollAnimatorBase> m_scrollAnimator; 395 mutable Member<ScrollAnimatorBase> m_scrollAnimator;
391 mutable Member<ProgrammaticScrollAnimator> m_programmaticScrollAnimator; 396 mutable Member<ProgrammaticScrollAnimator> m_programmaticScrollAnimator;
392 397
393 unsigned m_scrollbarOverlayStyle : 2; // ScrollbarOverlayStyle 398 unsigned m_scrollbarOverlayStyle : 2; // ScrollbarOverlayStyle
394 399
395 unsigned m_scrollOriginChanged : 1; 400 unsigned m_scrollOriginChanged : 1;
396 401
397 unsigned m_horizontalScrollbarNeedsPaintInvalidation : 1; 402 unsigned m_horizontalScrollbarNeedsPaintInvalidation : 1;
398 unsigned m_verticalScrollbarNeedsPaintInvalidation : 1; 403 unsigned m_verticalScrollbarNeedsPaintInvalidation : 1;
399 unsigned m_scrollCornerNeedsPaintInvalidation : 1; 404 unsigned m_scrollCornerNeedsPaintInvalidation : 1;
405 unsigned m_scrollbarsHidden : 1;
400 406
401 // There are 6 possible combinations of writing mode and direction. Scroll 407 // There are 6 possible combinations of writing mode and direction. Scroll
402 // origin will be non-zero in the x or y axis if there is any reversed 408 // origin will be non-zero in the x or y axis if there is any reversed
403 // direction or writing-mode. The combinations are: 409 // direction or writing-mode. The combinations are:
404 // writing-mode / direction scrollOrigin.x() set scrollOrigin.y() set 410 // writing-mode / direction scrollOrigin.x() set scrollOrigin.y() set
405 // horizontal-tb / ltr NO NO 411 // horizontal-tb / ltr NO NO
406 // horizontal-tb / rtl YES NO 412 // horizontal-tb / rtl YES NO
407 // vertical-lr / ltr NO NO 413 // vertical-lr / ltr NO NO
408 // vertical-lr / rtl NO YES 414 // vertical-lr / rtl NO YES
409 // vertical-rl / ltr YES NO 415 // vertical-rl / ltr YES NO
410 // vertical-rl / rtl YES YES 416 // vertical-rl / rtl YES YES
411 IntPoint m_scrollOrigin; 417 IntPoint m_scrollOrigin;
412 }; 418 };
413 419
414 } // namespace blink 420 } // namespace blink
415 421
416 #endif // ScrollableArea_h 422 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698