Disable overlay scrollbars in Blink when hidden by the compositor.

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 2202 matching lines @@
   TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("compositor-worker"),
                "LayerTreeHostImpl::SetLayerTreeMutator");
   mutator_ = std::move(mutator);
   mutator_->SetClient(this);
 }
 
 LayerImpl* LayerTreeHostImpl::ViewportMainScrollLayer() {
   return viewport()->MainScrollLayer();
 }
 
+void LayerTreeHostImpl::SetScrollbarsHidden(int layer_id, bool hidden) {
+  scrollbars_hidden_map_[layer_id] = hidden;
+  client_->SetNeedsCommitOnImplThread();

[aelias_OOO_until_Jul13, 2016/10/26 19:01:03]

Please check if any of the map entries changed and only SetNeedsCommit if so.

[bokan, 2016/10/27 20:56:46]

The map is cleared on each commit so that it contains only layers with changed
scrollbar visibility (to avoid iterating over all scroll layers each commit). We
could remove existing and non-equal entries rather than flipping the bit since
that means we've changed back and forth without a commit, but SetNeedsCommit
will have already been set by the first call.

Since this flag is synced one-way only, we don't have a record of what the main
thread thinks this value is so we can't compare against that either.

I've added this bit to LayerImpl so we can avoid spamming NeedsCommit if nothing
on impl has changed.

[aelias_OOO_until_Jul13, 2016/10/27 21:22:09]

OK.  Though with that bit added to LayerImpl, the scrollbars_hidden_map_ state
isn't needed anymore.  Please just put scrollbar visibility boolean into
info->scrollbars on every commit.  The early-return on the main thread side will
take care of avoiding substantive work from that.

+}
+
 void LayerTreeHostImpl::CleanUpTileManagerAndUIResources() {
   ClearUIResources();
   tile_manager_.FinishTasksAndCleanUp();
   resource_pool_ = nullptr;
   single_thread_synchronous_task_graph_runner_ = nullptr;
   image_decode_controller_ = nullptr;
 
   // We've potentially just freed a large number of resources on our various
   // contexts. Flushing now helps ensure these are cleaned up quickly
   // preventing driver cache growth. See crbug.com/643251
@@ skipping 1106 matching lines @@
 static void CollectScrollDeltas(ScrollAndScaleSet* scroll_info,
                                 LayerTreeImpl* tree_impl) {
   if (tree_impl->LayerListIsEmpty())
     return;
 
   int inner_viewport_layer_id =
       tree_impl->InnerViewportScrollLayer()
           ? tree_impl->InnerViewportScrollLayer()->id()
           : Layer::INVALID_ID;
 
-  return tree_impl->property_trees()->scroll_tree.CollectScrollDeltas(
+  tree_impl->property_trees()->scroll_tree.CollectScrollDeltas(
       scroll_info, inner_viewport_layer_id);
 }
 
+static void CollectScrollbarUpdates(
+    ScrollAndScaleSet* scroll_info,
+    std::unordered_map<int, bool>* scrollbars_hidden_map) {
+  scroll_info->scrollbars.reserve(scrollbars_hidden_map->size());
+  for (auto& pair : *scrollbars_hidden_map) {
+    scroll_info->scrollbars.push_back(
+        LayerTreeHostCommon::ScrollbarsUpdateInfo(pair.first, pair.second));
+  }
+  scrollbars_hidden_map->clear();
+}
+
 std::unique_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
   std::unique_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet());
 
   CollectScrollDeltas(scroll_info.get(), active_tree_.get());
+  CollectScrollbarUpdates(scroll_info.get(), &scrollbars_hidden_map_);
   scroll_info->page_scale_delta =
       active_tree_->page_scale_factor()->PullDeltaForMainThread();
   scroll_info->top_controls_delta =
       active_tree()->top_controls_shown_ratio()->PullDeltaForMainThread();
   scroll_info->elastic_overscroll_delta =
       active_tree_->elastic_overscroll()->PullDeltaForMainThread();
   scroll_info->swap_promises.swap(swap_promises_for_main_thread_scroll_update_);
 
   return scroll_info;
 }
@@ skipping 717 matching lines @@
   if (is_visible) {
     worker_context_visibility_ =
         worker_context->CacheController()->ClientBecameVisible();
   } else {
     worker_context->CacheController()->ClientBecameNotVisible(
         std::move(worker_context_visibility_));
   }
 }
 
 }  // namespace cc