Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2453513002: Change default behavior of --seed to be unix timestamp (Closed)
Patch Set: Address CL feedback from dpranke Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index ffd6dd796fa944703dc79a9328108b3b474cccee..dbe70a4f74ccecb52ef1ce6f1850b3376549effa 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -337,7 +337,7 @@ def parse_args(args):
"either in arguments or test list, "
"'natural' == use the natural order (default), "
"'random' == pseudo-random order. Seed can be specified "
- "via --seed, otherwise a default seed will be used.")),
+ "via --seed, otherwise it will default to the current unix timestamp.")),
optparse.make_option(
"--profile",
action="store_true",
@@ -383,7 +383,6 @@ def parse_args(args):
optparse.make_option(
"--seed",
type="int",
- default=4, # http://xkcd.com/221/
help=("Seed to use for random test order (default: %default). "
"Only applicable in combination with --order=random.")),
optparse.make_option(
@@ -547,6 +546,8 @@ def _set_up_derived_options(port, options, args):
total_shards = int(port.host.environ['GTEST_TOTAL_SHARDS']) + 1
options.run_part = '{0}:{1}'.format(shard_index, total_shards)
+ if not options.seed:
+ options.seed = port.host.time()
def _run_tests(port, options, args, printer):
_set_up_derived_options(port, options, args)

Powered by Google App Engine
This is Rietveld 408576698