Change FX_BOOL definition from int to bool.

Change FX_BOOL definition from int to bool.

If this CL sticks, we can then remove it entirely.

Committed: https://pdfium.googlesource.com/pdfium/+/dd65283408d9137e2f142e78dff2a1826baab5fd

[Tom Sepez, 2016-10-25 21:50:06]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 21:50:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-25 21:51:18]

Description was changed from

==========
Kill FX_BOOL.
==========

to

==========
Kill FX_BOOL.

Not likely to land as such, but there's a win-specific
compilation error enabled which may flag places where
FX_BOOL isn't true/false.
==========

[commit-bot: I haz the power, 2016-10-25 21:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:55:07]

Dry run: Try jobs failed on following builders:
  mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_no_v8/build...)

[Tom Sepez, 2016-10-25 22:23:30]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 22:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 22:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:30:08]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2567)

[Tom Sepez, 2016-10-25 23:05:41]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 23:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:08:38]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-10-26 16:04:50]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:05:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:08:42]

Dry run: Try jobs failed on following builders:
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2571)

[Tom Sepez, 2016-10-26 22:35:26]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 22:35:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:38:22]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-10-27 16:33:14]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 16:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 16:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 16:38:16]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2597)

[Tom Sepez, 2016-10-27 20:16:27]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:16:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:21:48]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-10-27 22:10:33]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 22:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:13:06]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-10-27 23:00:19]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:00:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:02:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:02:45]

Dry run: Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-10-28 16:36:26]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 16:36:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 16:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 16:39:05]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2613)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-10-28 18:35:32]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:55:28]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-10-28 18:58:16]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 19:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 19:15:39]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-10-28 19:24:01]

Description was changed from

==========
Kill FX_BOOL.

Not likely to land as such, but there's a win-specific
compilation error enabled which may flag places where
FX_BOOL isn't true/false.
==========

to

==========
Change FX_BOOL definition from int to bool.

If this CL sticks, we can then remove it entirely.
==========

[Tom Sepez, 2016-10-28 20:11:27]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 20:11:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-28 20:21:02]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-10-28 20:21:03]

Lei, for review.

[commit-bot: I haz the power, 2016-10-28 20:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:27:42]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-28 21:02:32]

Is the red win_skia experimental bot yours?

[Tom Sepez, 2016-10-28 21:05:32]

On 2016/10/28 21:02:32, Lei Zhang wrote:
> Is the red win_skia experimental bot yours?

Huh? where? which bot?

[Lei Zhang, 2016-10-28 21:09:27]

On 2016/10/28 21:05:32, Tom Sepez wrote:
> On 2016/10/28 21:02:32, Lei Zhang wrote:
> > Is the red win_skia experimental bot yours?
> 
> Huh? where? which bot?

https://build.chromium.org/p/tryserver.client.pdfium/builders/win_skia/builds...

I have " dispaly experimental trybot results" turned on in my Reltveld settings.

[Tom Sepez, 2016-10-28 21:10:25]

On 2016/10/28 21:09:27, Lei Zhang wrote:
> On 2016/10/28 21:05:32, Tom Sepez wrote:
> > On 2016/10/28 21:02:32, Lei Zhang wrote:
> > > Is the red win_skia experimental bot yours?
> > 
> > Huh? where? which bot?
> 
>
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_skia/builds...
> 
> I have " dispaly experimental trybot results" turned on in my Reltveld
settings.

Aha!  Yeah, its gotta be me.

[Tom Sepez, 2016-10-28 21:45:00]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 21:45:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-28 21:48:31]

Ok.  Green win_skia.

[Lei Zhang, 2016-10-28 21:50:14]

lgtm

[Tom Sepez, 2016-10-28 21:54:05]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-10-28 21:54:09]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:54:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:01:14]

Description was changed from

==========
Change FX_BOOL definition from int to bool.

If this CL sticks, we can then remove it entirely.
==========

to

==========
Change FX_BOOL definition from int to bool.

If this CL sticks, we can then remove it entirely.

Committed:
https://pdfium.googlesource.com/pdfium/+/dd65283408d9137e2f142e78dff2a1826baa...
==========

[commit-bot: I haz the power, 2016-10-28 22:01:16]

Committed patchset #15 (id:250001) as
https://pdfium.googlesource.com/pdfium/+/dd65283408d9137e2f142e78dff2a1826baa...

[dsinclair, 2016-10-29 18:27:02]

A revert of this CL (patchset #15 id:250001) has been created in
https://codereview.chromium.org/2461893002/ by dsinclair@chromium.org.

The reason for reverting is: Potentially blocking the roll, speculative revert.

See: https://codereview.chromium.org/2464643002/.