ios/web/web_state/ui/crw_web_controller.mm - Issue 2453473002: Zero-out crw_web_controller's container view delegate in dealloc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2453473002: Zero-out crw_web_controller's container view delegate in dealloc. (Closed)

Patch Set: Comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 9e29bc94709efec3fa06f70eef072c5a97c40069..db47e2a0096ecfdc310d3a6ff47d63eba51b21df 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -1135,6 +1135,8 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

DCHECK([NSThread isMainThread]);

DCHECK(_isBeingDestroyed); // 'close' must have been called already.

DCHECK(!_webView);

+ // TODO(crbug.com/662860): Don't set the delegate to nil.

+ [_containerView setDelegate:nil];

_touchTrackingRecognizer.get().touchTrackingDelegate = nil;

[[_webViewProxy scrollViewProxy] removeObserver:self];

[[NSNotificationCenter defaultCenter] removeObserver:self];

« no previous file with comments | « no previous file | ios/web/web_state/ui/crw_web_controller_container_view.h » ('j') | no next file with comments »