Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2453463008: Take into account fragment's margins while searching opportunities. (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Take into account fragment's margins while searching opportunities. FindLayoutOpportunityForFragment should take into account fragment's margins while searching opportunities. BUG=635619 Committed: https://crrev.com/e24bddabaa514377a42f3ce4cca004a44a2c7d66 Cr-Commit-Position: refs/heads/master@{#428042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +39 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Gleb Lanbin
4 years, 1 month ago (2016-10-27 01:45:52 UTC) #2
ikilpatrick
lgtm
4 years, 1 month ago (2016-10-27 16:12:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453463008/1
4 years, 1 month ago (2016-10-27 16:12:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 16:18:31 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:29:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e24bddabaa514377a42f3ce4cca004a44a2c7d66
Cr-Commit-Position: refs/heads/master@{#428042}

Powered by Google App Engine
This is Rietveld 408576698