Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2453463007: Convert editing/style/toggle-style-bold-italic.html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/toggle-style-bold-italic.html to utilize w3c test harness This patch converts "toggle-style-bold-italic.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior chagnes Committed: https://crrev.com/b3dad5b30e4e8e9387d00732ad1f8f57b0a4070c Cr-Commit-Position: refs/heads/master@{#427976}

Patch Set 1 : 2016-10-26T17:57:19 #

Total comments: 1

Patch Set 2 : 2016-10-27T14:52:51 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -82 lines) Patch
M third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic.html View 1 1 chunk +79 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
yosin_UTC9
PTAL Since I don't see differences among platform, this test script checks only on current ...
4 years, 1 month ago (2016-10-26 09:45:40 UTC) #5
Xiaocheng
https://codereview.chromium.org/2453463007/diff/1/third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic.html File third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic.html (right): https://codereview.chromium.org/2453463007/diff/1/third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic.html#newcode12 third_party/WebKit/LayoutTests/editing/style/toggle-style-bold-italic.html:12: ].join(''), I think we should have newlines and indentation ...
4 years, 1 month ago (2016-10-27 01:54:59 UTC) #8
yosin_UTC9
PTAL Update to follow review comments.
4 years, 1 month ago (2016-10-27 07:50:55 UTC) #11
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-27 07:53:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453463007/20001
4 years, 1 month ago (2016-10-27 08:01:56 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 09:16:23 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 09:18:45 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3dad5b30e4e8e9387d00732ad1f8f57b0a4070c
Cr-Commit-Position: refs/heads/master@{#427976}

Powered by Google App Engine
This is Rietveld 408576698