Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2453453002: Enable chrome://discards on Linux. (Closed)

Created:
4 years, 1 month ago by Georges Khalil
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, chrisha
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable chrome://discards on Linux. Tab manager was enabled on Linux a while ago but chrome://discards was never made available on that platform. This CL fixes that. Note that automatic discarding is still not available on Linux due to the lack of memory pressure subsystem on that platform. BUG=551995, 642327, 650158 Committed: https://crrev.com/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8 Cr-Commit-Position: refs/heads/master@{#428173}

Patch Set 1 : Enable chrome://discards on Linux. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Georges Khalil
PTAL.
4 years, 1 month ago (2016-10-27 14:06:38 UTC) #12
sky
LGTM
4 years, 1 month ago (2016-10-27 16:07:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453453002/20001
4 years, 1 month ago (2016-10-27 20:53:55 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-27 22:48:14 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:52:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2ee5e6f646b503fcb77a0597d8d38774e36aaa8
Cr-Commit-Position: refs/heads/master@{#428173}

Powered by Google App Engine
This is Rietveld 408576698