Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2453433003: MD Settings: Fix /handlers URL (Closed)

Created:
4 years, 1 month ago by tommycli
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Change /handlers URL Also removes a no longer needed URL constant. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2312a8c15df8cf4123a1f76d2e92b7d83991b603 Cr-Commit-Position: refs/heads/master@{#427727}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/route.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
tommycli
dbeam: PTAL. This just fixes the /handlers URL. Also for reference you can see https://docs.google.com/a/google.com/spreadsheets/d/1lhqLnlGp0PJuihg8Wz1zBx55LsbSdEASdOIjfZm-XIw/edit?usp=sharing, ...
4 years, 1 month ago (2016-10-26 00:16:37 UTC) #7
Dan Beam
lgtm but this is a weird URL
4 years, 1 month ago (2016-10-26 02:08:54 UTC) #10
tommycli
On 2016/10/26 02:08:54, Dan Beam wrote: > lgtm but this is a weird URL yeah.... ...
4 years, 1 month ago (2016-10-26 17:03:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453433003/20001
4 years, 1 month ago (2016-10-26 17:03:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 17:11:30 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:50:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2312a8c15df8cf4123a1f76d2e92b7d83991b603
Cr-Commit-Position: refs/heads/master@{#427727}

Powered by Google App Engine
This is Rietveld 408576698